Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TxHashSet Download Improvement #2984

Merged
merged 8 commits into from
Aug 1, 2019

Conversation

quentinlesceller
Copy link
Member

This PR introduces additional checks during TxHashSet download.

Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Makes sense. 👍

@antiochp antiochp added this to the 2.x.x milestone Aug 1, 2019
@antiochp
Copy link
Member

antiochp commented Aug 1, 2019

Doing some testing of this locally and seeing Invalid Block Time errors when attempting to sync. I don't think it is related - but it looks like "user testing" mode is maybe not working right now.
Working on getting it fixed before continuing testing of this.

Fix for the timestamp on the genesis block during user testing - #2986 (unrelated to this PR).

@antiochp
Copy link
Member

antiochp commented Aug 1, 2019

Tested locally in user testing syncing from one node to another. 👍

@antiochp antiochp merged commit f79d05b into mimblewimble:master Aug 1, 2019
@quentinlesceller quentinlesceller deleted the fix-007 branch August 1, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants