[2.x.x] Writeable protocol version aware #2856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
force-pushed
the
writeable_protocol_version_aware
branch
from
5fb1f22 to
9e9f3dd
Compare
antiochp
force-pushed
the
writeable_protocol_version_aware
branch
from
9e9f3dd to
e187f4b
Compare
antiochp
changed the title
|
Going to merge this. See #2824 for original context and discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the other "half" of #2824.
We now pass a "protocol version" into serialization/deserialization based on the version provided by our peer, or our local db storage.
This allows us to read/write different protocol versions in a robust way - making version negotiation across the p2p layer possible along with local db upgrades and backward compatibility.
This is not actively in use yet - everything remains on
protocol version 1but this will allow nodes to support (and upgrade safely) to the proposed kernel serialization in #2859.