[2.x.x] deserialization now protocol version aware #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiochp
changed the title
antiochp
force-pushed
the
readable_protocol_version_aware
branch
from
58f939e to
e3b7365
Compare
antiochp
changed the title
antiochp
changed the title
ignopeverell
approved these changes
May 20, 2019
antiochp
force-pushed
the
readable_protocol_version_aware
branch
from
5ce6046 to
825a56f
Compare
antiochp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR threads the
protocol_versionthrough from each active peer connection to the deserialization step when reading messages off the connection.This allows us to deserialize messages based on different versions for each peer (based on the protocol version supported by the peer).
kernel.read()demonstrates how we would access theprotocol_versionto modify the deserialization logic.ser::deserialize()is now "protocol version" awareProtocolVersionfromp2pcrate tocorecrate (ser.rs)