Gracefully shutdown if SIGINT was sent in TUI mode #2784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is needed for p2p thread management, currently there is no point where we could store thread handles and join themm because thread::join consume the caller, which is impossible in case of Arc. Also we don't need to check running flag constantly and it's easier to reason about the state.
hashmap
changed the title
hashmap
changed the title
antiochp
reviewed
May 3, 2019
| @@ -101,13 +101,8 @@ impl Server { | |||
| } | |||
| } | |||
|
|
|||
| info_callback(serv.clone()); | |||
| loop { | |||
antiochp
reviewed
May 3, 2019
| let running = Arc::new(AtomicBool::new(true)); | ||
| let _ = thread::Builder::new() | ||
| .name("ui".to_string()) | ||
| .spawn(move || { |
There was a problem hiding this comment.
So we now run the TUI in the main thread and not in a separate ui thread?
Is there any downside to this?
There was a problem hiding this comment.
It's symmetrical with non-tui case. Also to be fair I'm not sure, it seems that cursive creates a separate thread anyway, but I'm not an expert. What I see is that SIGINT is magically handled (in ncurses backend or most likely in C code, because I didn't find any traces of it in cursive) and it stops only UI, so we are able to call server.stop() in the main thread after that.
antiochp
added
the
release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2799
Also 2 Arc's were replaced by one server's instance.
It is needed for p2p thread management in #2778, currently there is no point where we could store thread handles and join them because
thread::joinconsume the caller, which is impossible in case of Arc.