Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If TUI is enabled Ctrl-C doesn't start graceful shutdown #2799

Closed
hashmap opened this issue May 2, 2019 · 0 comments · Fixed by #2784
Closed

If TUI is enabled Ctrl-C doesn't start graceful shutdown #2799

hashmap opened this issue May 2, 2019 · 0 comments · Fixed by #2784
Labels
bug

Comments

@hashmap
Copy link
Contributor

hashmap commented May 2, 2019

On all of my nodes except one (?) Ctrl-C kills TUI, but the process continue running. Second Ctrl-C kills the process but non of them start shutdown procedure. On one node process exits immediately without any attempt to shutdown (eg close connections).
It seems we don't handle SIGINT in TUI mode. I tried to add a handler in UI code but it's not invoked, I assume ncurses backend handles the signal.
@hashmap hashmap added the bug label May 2, 2019
@hashmap hashmap mentioned this issue May 2, 2019
Merged
hashmap added a commit that referenced this issue May 3, 2019
@hashmap
Gracefully shutdown if SIGINT was sent in TUI mode (#2784)
55cbdf5 
Fixes #2799

Also 2 Arc's were replaced by one server's instance.
It is needed for p2p thread management in #2778, currently there is no point where we could store thread handles and join them because thread::join
consume the caller, which is impossible in case of Arc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gracefully shutdown if SIGINT was sent in TUI mode cyclefortytwo/grin
1 participant
@hashmap