Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean-up the txhashset zip file and temp folder #2575

Merged
merged 5 commits into from
Feb 15, 2019
Merged

clean-up the txhashset zip file and temp folder #2575

merged 5 commits into from
Feb 15, 2019

Conversation

garyyu
Copy link
Contributor

@garyyu garyyu commented Feb 14, 2019

(cherry-pick from #2569)To obsolete #2354

Compare to #2354, this PR:

  1. don't need track the list of the zip files
  2. don't need to worry about tracking filenames and handling shutdown/restart etc.

@garyyu
clean-up the txhashset zip file and temp folder
d6d7d29 
(cherry picked from commit d840e3a)
@garyyu
rustfmt
0cb3079 
(cherry picked from commit b43057a)
@garyyu
adapt test_txhashset with the new zip_read function
eb4ecd2 
(cherry picked from commit 6cb78e7)
@garyyu
rustfmt
64a61ac 
(cherry picked from commit 13e73e9)
@garyyu
fix: the wrong folder when cleaning up old zips
5a5faf9 
(cherry picked from commit 5cc28be)
@garyyu garyyu added this to the 1.1.0 milestone Feb 14, 2019
@antiochp
Copy link
Member

Does this need to be 1.1.0? Feels simple enough to merge into master right now and target 1.0.2 (if this exists)?

antiochp
antiochp approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@antiochp antiochp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ignopeverell
Copy link
Contributor

@antiochp this isn't entirely technically motivated but I was thinking this improvement would be a good carrot to get more 1.1.0 upgrades.

@antiochp
Copy link
Member

👍 That makes sense. Do we have a rough timeline for when 1.1.0 might be released?

@ignopeverell
Copy link
Contributor

Not really but I was hoping the Windows support would be in there. That seems to be getting close.

@ignopeverell ignopeverell merged commit 2f5fbb3 into mimblewimble:milestone/1.1.0 Feb 15, 2019
@jaspervdm jaspervdm mentioned this pull request Mar 11, 2019
Closed
@quentinlesceller quentinlesceller mentioned this pull request Mar 26, 2019
Closed
This was referenced Apr 21, 2019
Closed
Merged
ignopeverell pushed a commit that referenced this pull request Apr 22, 2019
@garyyu @ignopeverell
Get back the lost code of #2575 (#2771)
b61b773
@antiochp antiochp added the release notes To be included in release notes (of relevant milestone). label Jun 5, 2019
@garyyu garyyu deleted the zip-cleanup-1.1.0 branch December 11, 2019 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antiochp antiochp antiochp approved these changes

Assignees
No one assigned
Labels
enhancement release notes To be included in release notes (of relevant milestone).
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@garyyu @antiochp @ignopeverell