Skip to content

fix: prevent crash when contains_all/any is used with empty array#41739

Merged
sre-ci-robot merged 2 commits intomilvus-io:masterfrom
xiaocai2333:fix_array_contains_empty_array
May 14, 2025
Merged

fix: prevent crash when contains_all/any is used with empty array#41739
sre-ci-robot merged 2 commits intomilvus-io:masterfrom
xiaocai2333:fix_array_contains_empty_array

Conversation

@xiaocai2333
Copy link
Copy Markdown
Contributor

issue: #41348

related and optimized by #41347

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 9, 2025
@sre-ci-robot sre-ci-robot requested review from bigsheeper and czs007 May 9, 2025 09:49
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 9, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 9, 2025

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@codecov
Copy link
Copy Markdown

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.48%. Comparing base (52950ce) to head (2fb19f6).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
...rnal/core/src/exec/expression/JsonContainsExpr.cpp 88.23% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #41739       +/-   ##
===========================================
+ Coverage   73.68%   80.48%    +6.80%     
===========================================
  Files         335     1523     +1188     
  Lines       30605   215100   +184495     
===========================================
+ Hits        22552   173130   +150578     
- Misses       8053    35749    +27696     
- Partials        0     6221     +6221     
Components Coverage Δ
Client 79.38% <ø> (∅)
Core 73.67% <91.30%> (-0.01%) ⬇️
Go 81.85% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/cachinglayer/Translator.h 100.00% <ø> (ø)
...rc/segcore/storagev1translator/ChunkTranslator.cpp 95.71% <100.00%> (+0.06%) ⬆️
...rnal/core/src/exec/expression/JsonContainsExpr.cpp 90.85% <88.23%> (+0.04%) ⬆️

... and 1189 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@czs007
Copy link
Copy Markdown
Collaborator

czs007 commented May 11, 2025

@xiaocai2333 [ FAILED ] Naive/ArrayInvertedIndexTest/6.ArrayContainsAny, where TypeParam = double

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Co-authored-by: Sangho Park <hoyaspark@gmail.com>
@xiaocai2333 xiaocai2333 force-pushed the fix_array_contains_empty_array branch from 7524aab to ec39958 Compare May 12, 2025 03:16
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels May 12, 2025
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@xiaocai2333
Copy link
Copy Markdown
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label May 12, 2025
@xiaocai2333 xiaocai2333 added this to the 2.5.12 milestone May 13, 2025
czs007 pushed a commit that referenced this pull request May 14, 2025
…1831)

issue: #41348

related and optimized by #41347

master pr: #41739
2.5 pr: #41756

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Co-authored-by: Sangho Park <hoyaspark@gmail.com>
sre-ci-robot pushed a commit that referenced this pull request May 14, 2025
#41756)

issue: #41348

related and optimized by #41347

master pr: #41739

---------

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Co-authored-by: Sangho Park <hoyaspark@gmail.com>
@sre-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007
Copy link
Copy Markdown
Collaborator

czs007 commented May 14, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit 4ead8ca into milvus-io:master May 14, 2025
24 of 25 checks passed
@xiaocai2333 xiaocai2333 deleted the fix_array_contains_empty_array branch May 22, 2025 06:51
nish112022 pushed a commit to nish112022/milvus that referenced this pull request May 22, 2025
milvus-io#41756)

issue: milvus-io#41348

related and optimized by milvus-io#41347

master pr: milvus-io#41739

---------

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Co-authored-by: Sangho Park <hoyaspark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants