fix: prevent crash when ARRAY_CONTAINS_ALL is used with empty array#41347
fix: prevent crash when ARRAY_CONTAINS_ALL is used with empty array#41347Hoyaspark wants to merge 4 commits intomilvus-io:masterfrom
Conversation
Signed-off-by: Sangho Park <hoyaspark@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Hoyaspark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Hoyaspark Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #41347 +/- ##
===========================================
+ Coverage 72.32% 81.87% +9.54%
===========================================
Files 310 1166 +856
Lines 28670 181134 +152464
===========================================
+ Hits 20736 148302 +127566
- Misses 7934 26692 +18758
- Partials 0 6140 +6140
🚀 New features to boost your workflow:
|
|
@Hoyaspark E2e jenkins job failed, comment |
…pr values Signed-off-by: Sangho Park <hoyaspark@gmail.com>
…Error Signed-off-by: Sangho Park <hoyaspark@gmail.com>
|
Replaced the panic in JsonContainsExpr with a SegcoreError exception when empty values are provided, and added a corresponding test case to verify the behavior. Let me know if you have any suggestions or better ideas on how to handle this. |
|
@Hoyaspark cpp-unit-test check failed, comment |
Signed-off-by: Sangho Park <hoyaspark@gmail.com>
|
@Hoyaspark go-sdk check failed, comment |
|
@Hoyaspark cpp-unit-test check failed, comment |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
milvus-io#41756) issue: milvus-io#41348 related and optimized by milvus-io#41347 master pr: milvus-io#41739 --------- Signed-off-by: Cai Zhang <cai.zhang@zilliz.com> Co-authored-by: Sangho Park <hoyaspark@gmail.com>
What this PR does
How it works
This PR adds a guard clause in PhyJsonContainsFilterExpr::EvalJsonContainsForDataSegment() that:
If not, it raises a PanicInfo(DataTypeInvalid) with a clear error message.
related issue : #41348