Skip to content

enhance: add expr filter ratio monitor params#41403

Merged
sre-ci-robot merged 1 commit intomilvus-io:2.5from
zhagnlu:add_filter_ratio_param_2.5
Apr 24, 2025
Merged

enhance: add expr filter ratio monitor params#41403
sre-ci-robot merged 1 commit intomilvus-io:2.5from
zhagnlu:add_filter_ratio_param_2.5

Conversation

@zhagnlu
Copy link
Copy Markdown
Contributor

@zhagnlu zhagnlu commented Apr 18, 2025

pr: #41402

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Apr 18, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 18, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2025

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2025

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@zhagnlu zhagnlu force-pushed the add_filter_ratio_param_2.5 branch from 8d01c17 to 50dd7ed Compare April 21, 2025 06:21
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 21, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 21, 2025

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 21, 2025

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@zhagnlu zhagnlu force-pushed the add_filter_ratio_param_2.5 branch from 50dd7ed to 7edb6fb Compare April 23, 2025 02:41
@sre-ci-robot sre-ci-robot added area/compilation area/dependency Pull requests that update a dependency file area/internal-api area/test sig/testing test/integration integration test size/XXL Denotes a PR that changes 1000+ lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Apr 23, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 23, 2025

@zhagnlu Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Apr 23, 2025
@zhagnlu zhagnlu force-pushed the add_filter_ratio_param_2.5 branch from 7edb6fb to 050a8eb Compare April 23, 2025 02:45
@sre-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Apr 23, 2025
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Apr 23, 2025
Signed-off-by: luzhang <luzhang@zilliz.com>
@zhagnlu zhagnlu force-pushed the add_filter_ratio_param_2.5 branch from 050a8eb to 66bb164 Compare April 23, 2025 06:26
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (8f2ccc2) to head (66bb164).
Report is 11 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #41403      +/-   ##
==========================================
- Coverage   82.66%   80.89%   -1.77%     
==========================================
  Files        1114     1421     +307     
  Lines      173584   203318   +29734     
==========================================
+ Hits       143485   164470   +20985     
- Misses      24335    33076    +8741     
- Partials     5764     5772       +8     
Components Coverage Δ
Client 79.65% <ø> (ø)
Core 70.68% <100.00%> (∅)
Go 82.77% <ø> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/exec/operator/FilterBitsNode.cpp 93.22% <100.00%> (ø)
internal/core/src/monitor/prometheus_client.h 100.00% <ø> (ø)

... and 335 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Apr 23, 2025
@czs007
Copy link
Copy Markdown
Collaborator

czs007 commented Apr 24, 2025

/lgtm

@czs007 czs007 added this to the 2.5.11 milestone Apr 24, 2025
@sre-ci-robot sre-ci-robot merged commit 66f40fb into milvus-io:2.5 Apr 24, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/compilation area/dependency Pull requests that update a dependency file area/internal-api area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/S Denotes a PR that changes 10-29 lines. test/integration integration test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants