Skip to content

enhance: add expr filter ratio monitor params#41402

Merged
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
zhagnlu:add_expr_ratio_param
Apr 29, 2025
Merged

enhance: add expr filter ratio monitor params#41402
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
zhagnlu:add_expr_ratio_param

Conversation

@zhagnlu
Copy link
Copy Markdown
Contributor

@zhagnlu zhagnlu commented Apr 18, 2025

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Apr 18, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 18, 2025
@zhagnlu zhagnlu mentioned this pull request Apr 18, 2025
Merged
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2025

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 18, 2025

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@sre-ci-robot
Copy link
Copy Markdown
Contributor

sre-ci-robot commented Apr 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhagnlu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhagnlu zhagnlu force-pushed the add_expr_ratio_param branch from eaf855f to aaa6d65 Compare April 21, 2025 06:27
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 21, 2025

@zhagnlu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 21, 2025

@zhagnlu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 21, 2025

@zhagnlu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

enhance: add expr filter ratio monitor params
7edb6fb 
Signed-off-by: luzhang <luzhang@zilliz.com>
@zhagnlu zhagnlu force-pushed the add_expr_ratio_param branch from aaa6d65 to 7edb6fb Compare April 23, 2025 02:46
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 23, 2025

⚠️ The sha of the head commit of this PR conflicts with #41403. Mergify cannot evaluate rules on this PR. ⚠️

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.45%. Comparing base (8ccb875) to head (7edb6fb).
Report is 63 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41402      +/-   ##
==========================================
+ Coverage   80.44%   80.45%   +0.01%     
==========================================
  Files        1487     1488       +1     
  Lines      211257   211510     +253     
==========================================
+ Hits       169954   170180     +226     
- Misses      35139    35164      +25     
- Partials     6164     6166       +2
Components Coverage Δ
Client 79.01% <ø> (ø)
Core 72.68% <100.00%> (+0.01%) ⬆️
Go 81.95% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/exec/operator/FilterBitsNode.cpp 93.22% <100.00%> (+0.36%) ⬆️
internal/core/src/monitor/prometheus_client.h 100.00% <ø> (ø)

... and 73 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhagnlu
Copy link
Copy Markdown
Contributor Author

zhagnlu commented Apr 23, 2025

/run-cpu-e2e

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 24, 2025

⚠️ The sha of the head commit of this PR conflicts with #41403. Mergify cannot evaluate rules on this PR. ⚠️

sre-ci-robot pushed a commit that referenced this pull request Apr 24, 2025
@zhagnlu
enhance: add expr filter ratio monitor params (#41403)
66f40fb 
pr: #41402

Signed-off-by: luzhang <luzhang@zilliz.com>
Co-authored-by: luzhang <luzhang@zilliz.com>
@mergify mergify bot added the ci-passed label Apr 25, 2025
@czs007
Copy link
Copy Markdown
Collaborator

czs007 commented Apr 29, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit cd60b96 into milvus-io:master Apr 29, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@czs007 czs007 czs007 approved these changes

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

Labels

approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/S Denotes a PR that changes 10-29 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhagnlu @sre-ci-robot @czs007