Skip to content

enhance: support binary range expression for json path index#41317

Merged
sre-ci-robot merged 3 commits intomilvus-io:2.5from
sunby:json_binary_expr_2.5
Apr 24, 2025
Merged

enhance: support binary range expression for json path index#41317
sre-ci-robot merged 3 commits intomilvus-io:2.5from
sunby:json_binary_expr_2.5

Conversation

@sunby
Copy link
Copy Markdown
Contributor

@sunby sunby commented Apr 15, 2025

pr: #41025
issue: #35528

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Apr 15, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 15, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 15, 2025

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@sunby sunby force-pushed the json_binary_expr_2.5 branch from d9470cb to 66fe992 Compare April 15, 2025 09:30
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 15, 2025

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 15, 2025

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 15, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 15, 2025

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sunby
Copy link
Copy Markdown
Contributor Author

sunby commented Apr 15, 2025

rerun go-sdk

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.89%. Comparing base (8f2ccc2) to head (4863afe).
Report is 8 commits behind head on 2.5.

Files with missing lines Patch % Lines
...ernal/core/src/exec/expression/BinaryRangeExpr.cpp 88.57% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #41317      +/-   ##
==========================================
- Coverage   82.66%   80.89%   -1.77%     
==========================================
  Files        1114     1421     +307     
  Lines      173584   203335   +29751     
==========================================
+ Hits       143485   164482   +20997     
- Misses      24335    33083    +8748     
- Partials     5764     5770       +6     
Components Coverage Δ
Client 79.65% <ø> (ø)
Core 70.71% <88.57%> (∅)
Go 82.77% <ø> (-0.03%) ⬇️
Files with missing lines Coverage Δ
...nternal/core/src/exec/expression/BinaryRangeExpr.h 91.66% <ø> (ø)
...ernal/core/src/exec/expression/BinaryRangeExpr.cpp 88.00% <88.57%> (ø)

... and 331 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sunby sunby force-pushed the json_binary_expr_2.5 branch from 60869cd to 879bfac Compare April 18, 2025 08:49
@czs007
Copy link
Copy Markdown
Collaborator

czs007 commented Apr 20, 2025

gs 0x0
*** Test killed with quit: ran too long (11m0s).
FAIL github.com/milvus-io/milvus/internal/querynodev2 660.072s

DONE 84 tests, 1 failure in 668.622s

sunby added 3 commits April 23, 2025 10:28
issue: milvus-io#35528

Signed-off-by: sunby <sunbingyi1992@gmail.com>
Signed-off-by: sunby <sunbingyi1992@gmail.com>
Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sunby sunby force-pushed the json_binary_expr_2.5 branch from 879bfac to 4863afe Compare April 23, 2025 02:28
@mergify mergify bot added the ci-passed label Apr 23, 2025
@zhengbuqian
Copy link
Copy Markdown
Collaborator

/lgtm

@sre-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4ac57f1 into milvus-io:2.5 Apr 24, 2025
27 of 30 checks passed
@czs007 czs007 added this to the 2.5.11 milestone Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants