Skip to content

enhance: support binary range expression for json path index#41025

Merged
sre-ci-robot merged 5 commits intomilvus-io:masterfrom
sunby:json_binary_expr
Apr 15, 2025
Merged

enhance: support binary range expression for json path index#41025
sre-ci-robot merged 5 commits intomilvus-io:masterfrom
sunby:json_binary_expr

Conversation

@sunby
Copy link
Copy Markdown
Contributor

@sunby sunby commented Apr 1, 2025

issue: #35528

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Apr 1, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Apr 1, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 78.94737% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.60%. Comparing base (cdf87e1) to head (e0dbca0).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...ernal/core/src/exec/expression/BinaryRangeExpr.cpp 78.94% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41025      +/-   ##
==========================================
+ Coverage   80.58%   80.60%   +0.02%     
==========================================
  Files        1475     1475              
  Lines      209728   209748      +20     
==========================================
+ Hits       169008   169070      +62     
+ Misses      34597    34566      -31     
+ Partials     6123     6112      -11
Components Coverage Δ
Client 79.59% <ø> (ø)
Core 72.34% <78.94%> (+0.02%) ⬆️
Go 82.02% <ø> (+0.02%) ⬆️
Files with missing lines Coverage Δ
...nternal/core/src/exec/expression/BinaryRangeExpr.h 91.66% <ø> (ø)
...ernal/core/src/exec/expression/BinaryRangeExpr.cpp 86.74% <78.94%> (+1.11%) ⬆️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added ci-passed and removed ci-passed labels Apr 1, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 2, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Copy Markdown
Contributor Author

sunby commented Apr 2, 2025

/run-cpu-e2e

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 2, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Copy Markdown
Contributor Author

sunby commented Apr 8, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Apr 8, 2025
sunby added 4 commits April 14, 2025 10:17
@sunby
binary expr
9fa6045 
Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sunby
ut
d80d745 
Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sunby
add ut
097f07f 
Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sunby
more ut
3c2fa2f 
Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sunby sunby force-pushed the json_binary_expr branch from a0355e9 to 3c2fa2f Compare April 14, 2025 02:18
@mergify mergify bot removed the ci-passed label Apr 14, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 14, 2025

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@sunby
fix
e0dbca0 
Signed-off-by: sunby <sunbingyi1992@gmail.com>
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 14, 2025

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 14, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Copy Markdown
Contributor Author

sunby commented Apr 14, 2025

/run-cpu-e2e

@sunby
Copy link
Copy Markdown
Contributor Author

sunby commented Apr 14, 2025

rerun go-sdk

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 14, 2025

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 14, 2025

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sunby
Copy link
Copy Markdown
Contributor Author

sunby commented Apr 15, 2025

rerun go-sdk

@sunby
Copy link
Copy Markdown
Contributor Author

sunby commented Apr 15, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Apr 15, 2025
@sunby sunby mentioned this pull request Apr 15, 2025
Merged
@liliu-z liliu-z self-assigned this Apr 15, 2025
liliu-z
liliu-z approved these changes Apr 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sre-ci-robot
Copy link
Copy Markdown
Contributor

sre-ci-robot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a953eae into milvus-io:master Apr 15, 2025
19 of 20 checks passed
divyaruhil pushed a commit to divyaruhil/milvus that referenced this pull request Apr 16, 2025
@sunby @divyaruhil
enhance: support binary range expression for json path index (milvus-…
e9308b1 
…io#41025)

issue: milvus-io#35528

---------

Signed-off-by: sunby <sunbingyi1992@gmail.com>
Signed-off-by: Divya <divyaruhil999@gmail.com>
sre-ci-robot pushed a commit that referenced this pull request Apr 24, 2025
@sunby
enhance: support binary range expression for json path index (#41317)
4ac57f1 
pr: #41025 
issue: #35528

---------

Signed-off-by: sunby <sunbingyi1992@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liliu-z liliu-z liliu-z approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@liliu-z liliu-z

Labels

approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sunby @sre-ci-robot @liliu-z