Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [Cherry-pick]Add collection name label for some metric (#36951) #37159

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Oct 25, 2024

pr: #36951

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 25, 2024
@aoiasd aoiasd changed the title enhance: Add collection name label for some metric (#36951) enhance: [Cherry-pick]Add collection name label for some metric (#36951) Oct 25, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Oct 25, 2024
Copy link
Contributor

mergify bot commented Oct 25, 2024

@aoiasd Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement labels Oct 25, 2024
@aoiasd
Copy link
Contributor Author

aoiasd commented Oct 25, 2024

pr: #36951

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Oct 29, 2024
@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: aoiasd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 8370caa into milvus-io:2.4 Oct 29, 2024
13 checks passed
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.12%. Comparing base (0b284cc) to head (e0766f8).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37159      +/-   ##
==========================================
- Coverage   80.55%   72.12%   -8.43%     
==========================================
  Files        1069     1069              
  Lines      165666   165675       +9     
==========================================
- Hits       133447   119500   -13947     
- Misses      27849    41809   +13960     
+ Partials     4370     4366       -4     
Files with missing lines Coverage Δ
internal/datacoord/index_meta.go 96.01% <100.00%> (ø)
internal/datacoord/meta.go 89.24% <100.00%> (ø)
internal/querynodev2/metrics_info.go 85.95% <100.00%> (+0.15%) ⬆️
internal/querynodev2/segments/collection.go 87.87% <100.00%> (-1.13%) ⬇️
pkg/metrics/datacoord_metrics.go 63.76% <100.00%> (ø)
pkg/metrics/querynode_metrics.go 100.00% <ø> (ø)

... and 224 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants