Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add collection name label for some metric #36951

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Oct 17, 2024

No description provided.

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 17, 2024
@tedxu
Copy link
Contributor

tedxu commented Oct 21, 2024

/lgtm

Copy link
Contributor

mergify bot commented Oct 21, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 21, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 21, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 21, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (49b5622) to head (1411fd0).
Report is 18 commits behind head on master.

Current head 1411fd0 differs from pull request most recent head 49393a2

Please upload reports for the commit 49393a2 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36951      +/-   ##
==========================================
- Coverage   83.27%   79.86%   -3.42%     
==========================================
  Files        1027     1310     +283     
  Lines      156560   183610   +27050     
==========================================
+ Hits       130371   146635   +16264     
- Misses      21039    31847   +10808     
+ Partials     5150     5128      -22     
Files with missing lines Coverage Δ
internal/datacoord/index_meta.go 96.08% <100.00%> (ø)
internal/datacoord/meta.go 89.15% <100.00%> (+0.10%) ⬆️
internal/querynodev2/metrics_info.go 85.95% <100.00%> (+0.15%) ⬆️
internal/querynodev2/segments/collection.go 91.25% <100.00%> (-1.19%) ⬇️
pkg/metrics/datacoord_metrics.go 65.27% <100.00%> (ø)
pkg/metrics/querynode_metrics.go 100.00% <ø> (ø)

... and 363 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Oct 22, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd aoiasd force-pushed the C8 branch 2 times, most recently from b71942a to dec7b0f Compare October 23, 2024 11:41
Copy link
Contributor

mergify bot commented Oct 23, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tedxu
Copy link
Contributor

tedxu commented Oct 25, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 22b917a into milvus-io:master Oct 25, 2024
16 of 17 checks passed
aoiasd added a commit to aoiasd/milvus that referenced this pull request Oct 25, 2024
aoiasd added a commit to aoiasd/milvus that referenced this pull request Oct 29, 2024
sre-ci-robot pushed a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants