Skip to content

Allow selecting "Polling" as the transport for socket.io connection #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Allow selecting "Polling" as the transport for socket.io connection #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b45098
Add "polling" to server transports array
goncalovf Sep 12, 2025
c906f12
Allow selecting transport with which to connect
goncalovf Sep 12, 2025
42d1412
Add empty final line to changed files
goncalovf Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions adb-proxy-socket/proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const app = express();
const server = http.createServer(app);
const io = new Server(server,
{
transports: ["websocket"],
transports: ["websocket", "polling"],
maxHttpBufferSize: 50 * 1024 * 1024
}
);
Expand Down Expand Up @@ -134,4 +134,4 @@ function sendToApplication(packet) {

server.listen(PORT, () => {
console.log(`adb-mcp Command proxy server running on ws://localhost:${PORT}`);
});
});
12 changes: 11 additions & 1 deletion uxp/id/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,16 @@
<p>&nbsp;</p>
<div>
<sp-checkbox id="chkConnectOnLaunch">Connect on Launch</sp-checkbox>
<div>
<sp-field-label for="transport">
<h4>Transport</h4>
</sp-field-label>
<sp-radio-group id="transport" vertical>
<sp-radio value="websocket" checked>WebSocket</sp-radio>
<sp-radio value="polling">Polling</sp-radio>
<sp-help-text>WebSocket is more performant, but Polling is more reliable.</sp-help-text>
</sp-radio-group>
</div>
</div>
<footer>
<div>
Expand All @@ -25,4 +35,4 @@
</footer>
</body>

</html>
</html>
31 changes: 29 additions & 2 deletions uxp/id/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const onCommandPacket = async (packet) => {
function connectToServer() {
// Create new Socket.IO connection
socket = io(PROXY_URL, {
transports: ["websocket"],
transports: [getTransport()],
});

socket.on("connect", () => {
Expand Down Expand Up @@ -108,6 +108,11 @@ function disconnectFromServer() {
}
}

function resetConnection() {
disconnectFromServer();
connectToServer();
}

function sendResponsePacket(packet) {
if (socket && socket.connected) {
socket.emit("command_packet_response", {
Expand Down Expand Up @@ -168,10 +173,32 @@ const getConnectOnLaunch = () => {
return JSON.parse(window.localStorage.getItem(CONNECT_ON_LAUNCH)) || false;
};

// Set checkbox state on page load
const TRANSPORT = "transport";

document
.getElementById("transport")
.addEventListener("change", function (event) {
window.localStorage.setItem(TRANSPORT, event.target.value);
resetConnection();
});

const getTransport = () => {
return window.localStorage.getItem(TRANSPORT) || "websocket";
};

// Set states on page load
document.addEventListener("DOMContentLoaded", () => {
document.getElementById("chkConnectOnLaunch").checked =
getConnectOnLaunch();

const transportValue = getTransport();

document
.getElementById(TRANSPORT)
.querySelectorAll("sp-radio")
.forEach(radio => {
radio.checked = radio.value === transportValue;
});
});

window.addEventListener("load", (event) => {
Expand Down