Allow selecting "Polling" as the transport for socket.io connection #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing this PR because, in commit 1465934, @mikechambers preferred to have the InDesign UXP plugin detect the OS and choose the correct socket options instead of making the user choose the options. |
|
thanks for pointing me in the right way for the solution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm unable to make InDesign connect to the proxy server on my Windows laptop through the WeBsocket transport. But the connection works just fine with the Polling transport. This PR adds a radio-group so users can select which transport to use to connect InDesign with the proxy server.
Note: even though the window's label in the screenshot reads "Premiere MCP Agent", this is in fact for InDesign. PR #13 will fix this window's label.