Fix C23 compatibility issues and warnings

lib/bound.c

@@ -192,11 +192,10 @@ crossings.  This may require replacing the original weave with one, two, or
 more new weaves.  If more than two are needed, do not set *one* or *two*.
 ------------------------------------------------------------------------------
 */
-void b_one_pair(list, list2, one, two)
-word  *list;    /* list of original inputs/outputs, modified by this routine */
-word  *list2;                      /* inputs/outputs of the second new weave */
-word  *one;                                   /* will one new weave suffice? */
-word  *two;                                  /* will two new weaves suffice? */
+void b_one_pair(word  *list,   /* list of original inputs/outputs, modified by this routine */
+                word  *list2,                     /* inputs/outputs of the second new weave */
+                word  *one,                                  /* will one new weave suffice? */
+                word  *two)                                 /* will two new weaves suffice? */
 {
   word   a;
   word   i;

lib/bound.h

@@ -103,7 +103,7 @@ There are three representations of weave boundaries.
 ---------------------------------------------------------------------------
 */
 #define b_cross( inp1, inp2, outp1, outp2) \
- (((inp1)<(inp2))==((inp2)<(outp1))==((outp1)<(outp2))==((inp1)<(outp2)))
+ ((((inp1)<(inp2))==((inp2)<(outp1)))==(((outp1)<(outp2))==((inp1)<(outp2))))
 
 
 /*

lib/dllink.c

@@ -71,8 +71,7 @@ void l_add(dllink *inp,     /* the next crossing in this string */
   This deletes a given dllink from a loop
 ------------------------------------------------------------------------------
 */
-void   l_del(l)
-dllink **l;
+void   l_del(dllink **l)
 {
   dllink  *ll = *l;
 

lib/order.c

@@ -26,7 +26,7 @@ if (1) \
 /*  This assumes that every crossing is used.
     This lists the crossings in an order my algorithm will hopefully like. */
 static void o_order2(
-    crossing  *k,
+    const crossing  *k,
     word      *oldorder,
     word      *order,
     word       crossings)
@@ -37,8 +37,8 @@ static void o_order2(
             *endp,
              tmp1,
              tmp2;
-  crossing  *kp,
-            *kp2;
+  const crossing  *kp,
+                  *kp2;
 
   for (ip = tab, endp = tab+crossings; ip != endp;) *(ip++) = 0;
   *order = oldorder[crossings-1];
@@ -69,7 +69,7 @@ static void o_order2(
 
 /*  This assumes that every crossing is used.
     This lists the crossings in an order my algorithm will hopefully like. */
-static void o_order1(crossing  *k,
+static void o_order1(const crossing  *k,
                      word      *oldorder,
                      word      *order,
                      word       crossings)
@@ -80,7 +80,7 @@ static void o_order1(crossing  *k,
             *endp,
              tmp1,
              tmp2;
-  crossing  *kp2;
+  const crossing  *kp2;
 
   for (ip = tab, endp = tab+crossings; ip != endp;) *(ip++) = 0;
   *order = oldorder[crossings-1];
@@ -110,7 +110,7 @@ static void o_order1(crossing  *k,
 static void o_add(word      *n,         /* in/out: the number of strings in the weave */
                   dllink   **boundary,
                   word      *going_in,  /* in/out: which strings are inputs */
-                  crossing  *k,
+                  const crossing  *k,
                   word       newcross,
                   Instruct  *answer)
 {
@@ -229,7 +229,7 @@ static void o_delete(word      *n,
 static void o_one_make(word      *n,
                        dllink   **boundary,
                        word      *going_in,
-                       crossing  *k,
+                       const crossing  *k,
                        word       which,
                        Instruct  *answer)
 {

test/test_example.c

@@ -40,7 +40,6 @@ int main(int argc, char *argv[])
     f = fopen(argv[1], "r");
     if (f == NULL)
     {
-        fclose(f);
         return 1;
     }