Fix C23 compatibility issues and warnings#19
Merged
dimpase merged 1 commit intomiguelmarco:masterfrom Mar 26, 2026
Merged
Conversation
- lib/bound.c: convert b_one_pair() from K&R to ANSI definition style - lib/bound.h: fix b_cross macro chained == (A==B==C==D -> (A==B)==(C==D)) - lib/dllink.c: convert l_del() from K&R to ANSI definition style - lib/order.c: propagate const to crossing* params/locals in o_order2, o_order1, o_add, o_one_make to match const-correct caller - test/test_example.c: remove fclose(NULL) when fopen returns NULL
Contributor
Author
Contributor
Author
Then tag a new version. |
Contributor
Author
|
Collaborator
|
OK, 1.04 is out |
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 3, 2026
needed for c23 compatibility, due to newer XCode see miguelmarco/libhomfly#19 and reports for Sage there ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41912 Reported by: Dima Pasechnik Reviewer(s): Chenxin Zhong
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 5, 2026
needed for c23 compatibility, due to newer XCode see miguelmarco/libhomfly#19 and reports for Sage there ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41912 Reported by: Dima Pasechnik Reviewer(s): Chenxin Zhong
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 6, 2026
sagemathgh-41912: bump libhomfly version to 1.04 needed for c23 compatibility, due to newer XCode see miguelmarco/libhomfly#19 and reports for Sage there ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41912 Reported by: Dima Pasechnik Reviewer(s): Chenxin Zhong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #16 and fix the errors in (https://github.com/sagemath/sage/actions/runs/23587561397/job/68684371207?pr=41879)
link to sagemath/sage#41879