issue #14: allow users to skip quiesce via Backup or VM

[sseago]

This is the plugin companion PR to migtools/kubevirt-datamover-controller#205

Setting the oadp.openshift.io/skip-quiesce annotation to "true" on the Velero Backup CR results setting oadp.openshift.io/skip-quiesce=true on all DataUploads for the backup. Setting it on the VirtualMachine CR sets it for just that one DataUpload. In addition, when skipping quiesce on all DataUploads in a backup, setting oadp.openshift.io/skip-quiesce=false on a single VM overrides the default skip quiesce and will quiesce just that one VM.

Setting as draft now until the controller PR merges and this PR gets go.mod updates.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 876e7272-ea2e-4ce4-bd6d-41a64726146a

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[sseago]

This needs update to handle auto-detect behavior once migtools/kubevirt-datamover-controller#218 merges.

[sseago]

Updated to handle the auto-detect logic from migtools/kubevirt-datamover-controller#218

Still draft, and not yet tested since that PR still needs some changes first.

[sseago]

Tested with the latest controller and operator code and ready for review.

[kaovilai]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [kaovilai,shubham-pampattiwar,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kaovilai]

/cherry-pick oadp-1.6

[openshift-cherrypick-robot]

@kaovilai: once the present PR merges, I will cherry-pick it on top of oadp-1.6 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick oadp-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[weshayutin]

/test virt-kdm-e2e-test-aws

[openshift-cherrypick-robot]

@kaovilai: #51 failed to apply on top of branch "oadp-1.6":

Applying: feat: add SkipQuiesce annotation logic to DataUpload creation
Applying: update go.mod/go.sum to controller PR branch
Using index info to reconstruct a base tree...
M	go.mod
M	go.sum
Falling back to patching base and 3-way merge...
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
Auto-merging go.sum
CONFLICT (content): Merge conflict in go.sum
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0002 update go.mod/go.sum to controller PR branch

Details

In response to this:

/cherry-pick oadp-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.