Detect VMI guest-agent availability before quiesce, with explicit user override by Copilot · Pull Request #218 · migtools/kubevirt-datamover-controller

Copilot · 2026-09-01T21:13:49Z

KubeVirt datamover backups always attempted to quiesce the guest filesystem, producing noisy freeze-failure warnings on VMs without a QEMU guest agent (e.g. Cirros test VMs). The controller now makes the quiesce decision from the VM's guest-agent status instead of requiring workload-specific annotations.

Guest-agent detection

Added common.IsGuestAgentConnected(vmi): reports whether VirtualMachineInstance.Status.Conditions[type=AgentConnected].Status == True.
Added determineSkipQuiesce in the DataUpload controller: fetches the VM's VMI and sets VirtualMachineBackup.Spec.SkipQuiesce accordingly. If the VMI can't be fetched, defaults to skip-quiesce (crash-consistent) as the safe fallback.

Explicit user override

New kubevirt-datamover.io/quiesce annotation on DataUpload: "true" forces quiesce, "false" forces skip-quiesce, regardless of guest-agent state. Any other value (or unset) falls back to auto-detection. The override always takes precedence.

metadata:
  annotations:
    kubevirt-datamover.io/quiesce: "false"  # force crash-consistent backup

Wiring & permissions

ensureVMBackup now threads the resolved skipQuiesce value into the created VirtualMachineBackup spec.
Added RBAC for get;list;watch on virtualmachineinstances; config/rbac/role.yaml regenerated via make manifests.

Documentation

README documents the default auto-detection behavior and override annotation, with precedence rules.

Fixes Detect VMI guest-agent availability before quiesce and support user override #217

openshift-ci · 2026-09-01T21:14:00Z

Hi @Copilot. Thanks for your PR.

I'm waiting for a migtools member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Co-authored-by: kaovilai <11228024+kaovilai@users.noreply.github.com>

shubham-pampattiwar · 2026-09-02T17:39:01Z

+	}
+
+	vmi := &kubevirtcorev1.VirtualMachineInstance{}
+	if err := r.Get(ctx, types.NamespacedName{Name: vmRef.Name, Namespace: vmRef.Namespace}, vmi); err != nil {


Could we use r.APIReader for this lookup when it is configured, with the cached client as a fallback? This is a one-shot safety decision, and a stale cached VMI can still report AgentConnected=True after the agent has disconnected. That would create SkipQuiesce=false and reintroduce the freeze warning this PR is meant to avoid. The controller already uses APIReader for fresh VMB status reads.

shubham-pampattiwar · 2026-09-02T17:39:14Z

+- apiGroups:
+  - kubevirt.io
+  resources:
+  - virtualmachineinstances


Please propagate this new virtualmachineinstances permission to the OADP Operator manifests as part of this change. The controller is deployed through OADP Operator, which vendors this RBAC into config/kubevirt-datamover-controller_rbac/role.yaml and the bundle CSV. Without updating that copy, OADP deployments will not have permission to read VMIs and will always fall back to skip-quiesce.

shubham-pampattiwar · 2026-09-02T17:39:25Z

+		},
+	}
+
+	tests := []struct {


Could we add cases for an invalid or "auto" annotation value and for explicit "false" when the VMI is missing? These are documented behaviors and are especially relevant to the plugin integration, where absent/auto means automatic detection and false must remain an explicit override.

sseago · 2026-09-02T17:48:03Z

+	// controller quiesces only when the VM's VirtualMachineInstance
+	// reports status.conditions[type=AgentConnected].status == "True".
+	// This override always takes precedence over automatic detection.
+	AnnotationQuiesce = "kubevirt-datamover.io/quiesce"


Lets stick with SkipQuiesce, since that's the name of the VMBackup spec field. So across this PR, s/AnnotationQuiesce/AnnotationSkipQuiesce/, change the value to "kubevirt-datamover.io/skipQuiesce, with the appropriate s/false/true/ wherever needed.

sseago · 2026-09-02T17:48:31Z

+// backup failure from attempting to quiesce a VM whose agent state is
+// unknown.
+func (r *KubeVirtDataUploadReconciler) determineSkipQuiesce(ctx context.Context, logger logr.Logger, du *velerov2alpha1.DataUpload, vmRef *common.VMReference) bool {
+	if raw, ok := du.Annotations[common.AnnotationQuiesce]; ok {


SkipQuiesce

sseago · 2026-09-02T17:48:47Z

+	if raw, ok := du.Annotations[common.AnnotationQuiesce]; ok {
+		if override, err := strconv.ParseBool(raw); err == nil {
+			logger.Info("Quiesce explicitly overridden via annotation", "quiesce", override)
+			return !override


s/!overrride/override/

- Rename AnnotationQuiesce -> AnnotationSkipQuiesce, matching the VirtualMachineBackup.Spec.SkipQuiesce field name, with inverted semantics: "true" forces skip-quiesce, "false" forces quiesce. - Use r.APIReader (uncached) for the VMI lookup when configured, since this is a one-shot safety decision and a stale cached VMI can still report AgentConnected=True after the agent disconnected. - Fix double-negative typo (!override -> override) that fell out of the rename. - Add test coverage for invalid/"auto" annotation values and an explicit force-quiesce override when no VMI exists. Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>

sseago · 2026-09-03T19:46:02Z

/lgtm

openshift-ci · 2026-09-03T19:50:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Copilot, shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [shubham-pampattiwar,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-datamover-controller PR migtools/kubevirt-datamover-controller#218 adds a virtualmachineinstances get/list/watch permission needed for its guest-agent-based quiesce detection. Propagate it here so OADP-deployed controllers actually have it, instead of always falling back to skip-quiesce. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

sseago · 2026-09-04T14:14:12Z

/cherry-pick oadp-1.6

openshift-cherrypick-robot · 2026-09-04T14:14:51Z

@sseago: #218 failed to apply on top of branch "oadp-1.6":

Patch is empty.
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To record the empty patch as an empty commit, run "git am --allow-empty".
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Details

In response to this:

/cherry-pick oadp-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubevirt-datamover-controller PR migtools/kubevirt-datamover-controller#218 adds a virtualmachineinstances get/list/watch permission needed for its guest-agent-based quiesce detection. Propagate it here so OADP-deployed controllers actually have it, instead of always falling back to skip-quiesce. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

- Rename AnnotationQuiesce -> AnnotationSkipQuiesce, matching the VirtualMachineBackup.Spec.SkipQuiesce field name, with inverted semantics: "true" forces skip-quiesce, "false" forces quiesce. - Use r.APIReader (uncached) for the VMI lookup when configured, since this is a one-shot safety decision and a stale cached VMI can still report AgentConnected=True after the agent disconnected. - Fix double-negative typo (!override -> override) that fell out of the rename. - Add test coverage for invalid/"auto" annotation values and an explicit force-quiesce override when no VMI exists. Signed-off-by: Tiger Kaovilai <passawit.kaovilai@gmail.com>

kubevirt-datamover-controller PR migtools/kubevirt-datamover-controller#218 adds a virtualmachineinstances get/list/watch permission needed for its guest-agent-based quiesce detection. Propagate it here so OADP-deployed controllers actually have it, instead of always falling back to skip-quiesce. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

Initial plan

05eaf20

Copilot AI assigned Copilot and kaovilai Sep 1, 2026

openshift-ci Bot added do-not-merge/work-in-progress needs-ok-to-test labels Sep 1, 2026

Copilot started work on behalf of kaovilai September 1, 2026 21:14 View session

Copilot AI linked an issue Sep 1, 2026 that may be closed by this pull request

Detect VMI guest-agent availability before quiesce and support user override #217

Closed

Copilot AI and others added 2 commits September 1, 2026 21:30

Add VMI guest-agent-based quiesce detection with explicit override

8fcc68f

Co-authored-by: kaovilai <11228024+kaovilai@users.noreply.github.com>

Address code review: use consistent log level for quiesce decision

74a3320

Co-authored-by: kaovilai <11228024+kaovilai@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Improve quiesce behavior based on VMI guest-agent availability~~ Detect VMI guest-agent availability before quiesce, with explicit user override Sep 1, 2026

Copilot finished work on behalf of kaovilai September 1, 2026 21:35

Copilot AI requested a review from kaovilai September 1, 2026 21:35

kaovilai marked this pull request as ready for review September 2, 2026 17:09

openshift-ci Bot removed the do-not-merge/work-in-progress label Sep 2, 2026

openshift-ci Bot requested a review from sseago September 2, 2026 17:10

shubham-pampattiwar reviewed Sep 2, 2026

View reviewed changes

sseago reviewed Sep 2, 2026

View reviewed changes

This was referenced Sep 3, 2026

fix(#14): default SkipQuiesce=false, opt-in application-consistent backup #205

Closed

issue #14: allow users to skip quiesce via Backup or VM migtools/kubevirt-datamover-plugin#51

Merged

sseago approved these changes Sep 3, 2026

View reviewed changes

openshift-ci Bot assigned sseago Sep 3, 2026

openshift-ci Bot added lgtm approved labels Sep 3, 2026

kaovilai mentioned this pull request Sep 3, 2026

fix: vendor virtualmachineinstances RBAC from KDM PR #218 openshift/oadp-operator#2435

Merged

shubham-pampattiwar approved these changes Sep 3, 2026

View reviewed changes

openshift-merge-bot Bot merged commit 02fe1a7 into oadp-dev Sep 4, 2026
12 checks passed

openshift-merge-bot Bot deleted the copilot/detect-vmi-guest-agent-availability branch September 4, 2026 01:12

sseago mentioned this pull request Sep 4, 2026

[oadp-1.6] Detect VMI guest-agent availability before quiesce, with explicit user override #230

Merged

kaovilai mentioned this pull request Sep 14, 2026

Handle guest agent connectivity and SkipQuiesce for VirtualMachineBackup #14

Closed

6 tasks

Navigation Menu

Detect VMI guest-agent availability before quiesce, with explicit user override - #218

Detect VMI guest-agent availability before quiesce, with explicit user override#218
openshift-merge-bot[bot] merged 4 commits into
oadp-devfrom
copilot/detect-vmi-guest-agent-availability

Copilot AI commented Sep 1, 2026 •

edited

Loading

Uh oh!

openshift-ci Bot commented Sep 1, 2026

Uh oh!

shubham-pampattiwar Sep 2, 2026

Uh oh!

shubham-pampattiwar Sep 2, 2026

Uh oh!

shubham-pampattiwar Sep 2, 2026

Uh oh!

sseago Sep 2, 2026

Uh oh!

sseago Sep 2, 2026

Uh oh!

sseago Sep 2, 2026

Uh oh!

sseago commented Sep 3, 2026

Uh oh!

openshift-ci Bot commented Sep 3, 2026

Uh oh!

Uh oh!

sseago commented Sep 4, 2026

Uh oh!

openshift-cherrypick-robot commented Sep 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Copilot AI commented Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Guest-agent detection

Explicit user override

Wiring & permissions

Documentation

Uh oh!

openshift-ci Bot commented Sep 1, 2026

Uh oh!

shubham-pampattiwar Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

shubham-pampattiwar Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

shubham-pampattiwar Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

sseago Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

sseago Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

sseago Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

sseago commented Sep 3, 2026

Uh oh!

openshift-ci Bot commented Sep 3, 2026

Uh oh!

Uh oh!

sseago commented Sep 4, 2026

Uh oh!

openshift-cherrypick-robot commented Sep 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented Sep 1, 2026 •

edited

Loading