Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#951): fixed voteId filtering for POST /api/votes/<combatId> #952

Merged
merged 3 commits into from
May 13, 2024

Conversation

AlejandroSuero
Copy link
Contributor

@AlejandroSuero AlejandroSuero commented May 8, 2024

Descripción

Al hacer click en el combate 2v2 en https://lavelada.es/pronosticos. Se producía un error por el filtrado, introducido en la PR #947, a la hora de hacer POST /api/votes/<combatId>.

Problema solucionado

Fixes #951

Cambios propuestos

  1. Mantener filtrado si no es 2v2
  2. Si es 2v2, ver si el boxeador a filtrar se encuentra en voteId.

Capturas de pantalla (si corresponde)

voteId-filtering-fixex.mp4

Comprobación de cambios

  • He revisado que no haya ninguna PR (pull request) ya abierta con un problema similar, siguiendo el apartado de buenas prácticas
  • He revisado localmente los cambios para asegurarme de que no haya errores ni problemas.
  • He probado estos cambios en múltiples dispositivos y navegadores para asegurarme de que la landing page se vea y funcione correctamente.
  • He actualizado la documentación, si corresponde.

Copy link

vercel bot commented May 8, 2024

@AlejandroSuero is attempting to deploy a commit to the midudev pro Team on Vercel.

A member of the Team first needs to authorize it.

@AlejandroSuero AlejandroSuero changed the title fix(#951): fixed voteId filtering fix(#951): fixed voteId filtering for POST /api/votes/<combatId> May 8, 2024
src/pages/api/votes/[combatId].ts Outdated Show resolved Hide resolved
@midudev midudev merged commit 4a0b853 into midudev:main May 13, 2024
1 of 3 checks passed
@AlejandroSuero AlejandroSuero deleted the feature/fix-votes-filtering branch May 13, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error al votar zeling y nissaxter
3 participants