Fix bug when passing an unrelated boxer id as a voteId to POST /api/votes/<combatId>
endpoint
#947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descripción
A malicious user could do a call to
POST /api/votes/<combatId>
endpoint passing an arbitrary boxer id, i.e votingguanyar
in1-agustin-51-vs-carreraaa
combat.To mitigate this issue, we can implement filtering on the
voteId
from combat boxers' IDs. This would prevent the submission or voting of any arbitrary boxer ID that isn't associated with the specified combat.Problema solucionado
Fix bug when passing an unrelated boxer id as a
voteId
toPOST /api/votes/<combatId>
endpoint.Cambios propuestos
Filter
voteId
from combat boxers ids to prevent passing or voting an arbitrary boxer id not related to the given combatCapturas de pantalla (si corresponde)
Comprobación de cambios
Impacto potencial
Contexto adicional
Enlaces útiles