Skip to content

LargeFileUpload - node js stream support and progress handling, rollup library updates #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Mar 25, 2021
Merged

LargeFileUpload - node js stream support and progress handling, rollup library updates #401

merged 21 commits into from
Mar 25, 2021

Conversation

@nikithauc
Copy link
Contributor

@nikithauc nikithauc commented Mar 11, 2021

Fixes #320 , #305, #380 .

  • Introducing new classes StreamUpload and FileUpload implementing the FileObject interface and having the sliceFile logic.
  • Added a Progress interface for progress handling.
  • Updates roll up libraries, added copyright.

@nikithauc nikithauc added this to the 3.0.0 milestone Mar 11, 2021
This was linked to issues Mar 11, 2021
Node.js stream support missing in LargFileUploadTask #320
Closed
LargeFileUploadTask .upload() progress handler #305
Closed
Update rollup dependencies #380
Closed
@nikithauc nikithauc requested a review from ddyett March 11, 2021 23:36
zengin
zengin suggested changes Mar 12, 2021
View reviewed changes
baywet
baywet suggested changes Mar 12, 2021
View reviewed changes
@nikithauc nikithauc marked this pull request as draft March 17, 2021 08:32
@nikithauc nikithauc marked this pull request as ready for review March 18, 2021 00:09
baywet
baywet suggested changes Mar 18, 2021
View reviewed changes
@baywet
Copy link
Member

baywet commented Mar 18, 2021

I missed one commit in my previous review, sorry about that, resolved the things are are already resolved. Only a few things left :)

@nikithauc
Copy link
Contributor Author

nikithauc commented Mar 18, 2021

I missed one commit in my previous review, sorry about that, resolved the things are are already resolved. Only a few things left :)

Thank you for the review! I liked the idea to use generics.

@nikithauc nikithauc requested review from baywet and zengin March 18, 2021 18:31
zengin
zengin approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@zengin zengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking the proposed changes.

@nikithauc nikithauc merged commit 9ad1150 into 3.0.0 Mar 25, 2021
@mdybich mdybich mentioned this pull request Apr 21, 2021
Closed
@nikithauc nikithauc deleted the nikithauc/stream-support branch May 3, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nmetulev nmetulev Awaiting requested review from nmetulev

@MIchaelMainer MIchaelMainer Awaiting requested review from MIchaelMainer

@ddyett ddyett Awaiting requested review from ddyett

2 more reviewers

@zengin zengin zengin approved these changes

@baywet baywet baywet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking change

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

Update rollup dependencies Node.js stream support missing in LargFileUploadTask LargeFileUploadTask .upload() progress handler

4 participants

@nikithauc @baywet @zengin