Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storybook footer accessibility #2369

Merged
merged 3 commits into from
Jun 1, 2023

Conversation

gavinbarron
Copy link
Member

@gavinbarron gavinbarron commented May 31, 2023

Closes #2247 #2245

PR Type

  • Bugfix

Description of the changes

moves the footer into the side bar and makes links in the footer focusable

PR checklist

  • Project builds (yarn build) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)
  • All public APIs (classes, methods, etc) have been documented following the jsdoc syntax
  • Stories have been added and existing stories have been tested
  • Added appropriate documentation. Docs PR:
  • Accessibility tested and approved
  • License header has been added to all new source files (yarn setLicense)
  • Contains NO breaking changes

Other information

moves the footer into the side bar and makes links in the footer focusable
@gavinbarron gavinbarron requested a review from a team as a code owner May 31, 2023 20:33
@ghost
Copy link

ghost commented May 31, 2023

Thank you for creating a Pull Request @gavinbarron.

This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:

  • I have verified a documentation PR has been linked and is approved (or not applicable)
  • I have ran this PR locally and have tested the fix/feature
  • I have verified that stories have been added to storybook (or not applicable)
  • I have tested existing stories in storybook to verify no regression has occured
  • I have tested the solution in at least two browsers (Edge + 1 non-Chromium based browser)

@github-actions
Copy link

The updated storybook is available here

1 similar comment
@github-actions
Copy link

The updated storybook is available here

@sebastienlevert
Copy link
Contributor

@gavinbarron on mobile the footer is at the same place and hides the menus at the bottom of the screen.

@gavinbarron gavinbarron requested review from musale and Mnickii June 1, 2023 15:29
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

The updated storybook is available here

Copy link
Contributor

@sebastienlevert sebastienlevert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

The updated storybook is available here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment