-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: storybook footer accessibility #2369
Conversation
moves the footer into the side bar and makes links in the footer focusable
Thank you for creating a Pull Request @gavinbarron. This is a checklist for the PR reviewer(s) to complete before approving and merging this PR:
|
The updated storybook is available here |
1 similar comment
The updated storybook is available here |
@gavinbarron on mobile the footer is at the same place and hides the menus at the bottom of the screen. |
The updated storybook is available here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The updated storybook is available here |
Closes #2247 #2245
PR Type
Description of the changes
moves the footer into the side bar and makes links in the footer focusable
PR checklist
yarn build
) and changes have been tested in at least two supported browsers (Edge + non-Chromium based browser)yarn setLicense
)Other information