Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Freeway-Bug}[MGTP-Content Info links]: 'Privacy & cookies', 'Terms of user' links under 'Microsoft Graph toolkit playground' page is not accessible using Keyboard. #2245

Closed
vagpt opened this issue May 8, 2023 · 5 comments · Fixed by #2369

Comments

@vagpt
Copy link
Collaborator

vagpt commented May 8, 2023

Test Environment:
OS Build: Windows 11
Version: 22H2 (OS Build 25300.1000)
Browser: Edge dev
Browser Version 114.0.1807.5 (Official build) dev (64-bit)
URL: Components / mgt-agenda / Properties - Preferred Timezone ⋅ Storybook
User ID: V-id

Pre-requisites:

  1. Navigate using keyboard only.

Repro Steps:

  1. Open the above URL and login with valid credentials.
  2. The ‘Microsoft Graph Toolkit Playground' Overview page will get displayed.
  3. Try to navigate on the 'Privacy & cookies', 'Terms of user' content info links using tab key, arrow keys.
  4. Observe the issue.

Actual Result:
Keyboard users is not able to access 'Privacy & cookies', 'Terms of user' links under 'Microsoft Graph toolkit playground' page using Tab key/arrow key.

Observation:
The 'links' are activated when the user selects using mouse.

Expected result:
''Privacy & cookies', 'Terms of user' links under 'Microsoft Graph toolkit playground' page should be accessible with keyboard.

User experience:
It will be difficult for the keyboard users to access the links and to perform functionality if the controls are not accessible with keyboard navigation. Hence, they are blocked from performing action.

WCAG Reference link:
https://www.w3.org/TR/UNDERSTANDING-WCAG20/keyboard-operation-keyboard-operable.html

"Have feedback to share on Bugs ? Please help fill Trusted Tester Bug Feedback (office.com)

MAS2 1 1-Privacy and Cookies options are not accessible through the keyboard

Uploading WCAG2.1.1-Keyboard users not able to access 'Privacy & cookies', 'Terms of user' links under 'Microsoft Graph toolkit playground' page using Tab keyarrow key..mp4…

@ghost
Copy link

ghost commented May 8, 2023

Hello vagpt, thank you for opening an issue with us!

I have automatically added a "needs triage" label to help get things started. Our team will analyze and investigate the issue, and escalate it to the relevant team if possible. Other community members may also look into the issue and provide feedback 🙌

@sebastienlevert sebastienlevert moved this from Needs Triage 🔍 to Todo 📃 in Graph Toolkit May 8, 2023
@gavinbarron
Copy link
Member

This is an interesting one. Because of the DOM order of the footer these would create a strange tabbing order when they become accessible with the keyboard.

I wonder if we can inject it between the sidebar and the story area so that tab ordering is down the sidebar across the footer and back to the top of the story area.

We can't have it at the end of the DOM (after the editor pane) as the editor pane traps focus can't be tabbed out of....

@gavinbarron
Copy link
Member

@sebastienlevert I'd love your thoughts on this one, it's a structural issue with our page along with someone making these links non-tabbable

@sebastienlevert
Copy link
Contributor

Now that we have a "homepage" for the Playground... Maybe we could drop this content over there?

@vagpt vagpt changed the title [MGTP-Content Info links]: 'Privacy & cookies', 'Terms of user' links under 'Microsoft Graph toolkit playground' page is not accessible using Keyboard. {Freeway-Bug}[MGTP-Content Info links]: 'Privacy & cookies', 'Terms of user' links under 'Microsoft Graph toolkit playground' page is not accessible using Keyboard. May 30, 2023
@gavinbarron gavinbarron self-assigned this May 31, 2023
@gavinbarron gavinbarron moved this from Todo 📃 to In Progress 🚧 in Graph Toolkit May 31, 2023
@gavinbarron gavinbarron linked a pull request May 31, 2023 that will close this issue
7 tasks
@gavinbarron gavinbarron moved this from In Progress 🚧 to In Review 💭 in Graph Toolkit May 31, 2023
@gavinbarron gavinbarron modified the milestones: v3.0.0, v3.1.0 Jun 5, 2023
@vagpt
Copy link
Collaborator Author

vagpt commented Jun 6, 2023

This issue is working fine on the environment below, hence closing this issue.

Test Environment:
URL: https://mgt.dev/next/v3/?path=/story/overview--page
OS Version: 23H2(Os Build 25375.1)
Browser Version: Version 115.0.1880.3 (Official build) dev (64-bit)

Attachment:

Privacy.and.Cookies.and.Terms.of.User.links.are.accessible.now.mp4

@vagpt vagpt closed this as completed Jun 6, 2023
@github-project-automation github-project-automation bot moved this from In Review 💭 to Done ✔️ in Graph Toolkit Jun 6, 2023
@sebastienlevert sebastienlevert modified the milestones: v3.1.0, v3.0.0 Jun 15, 2023
@Raisul123 Raisul123 added the MicrosoftGraphToolkitPlayground_Web fetch bug data from the db for accessibility label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants