Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: download api manifest #2572

Open
wants to merge 96 commits into
base: dev
Choose a base branch
from
Open

Feature: download api manifest #2572

wants to merge 96 commits into from
+1,122 −200

Conversation

thewahome
Copy link
Collaborator

@thewahome thewahome commented May 15, 2023 •
edited by Onokaev
Loading

Overview

Shows what to do with an API Manifest when you download it
Closes #2446
Closes #2409
Closes #2687

Testing Instructions

  • Add items to a collection
  • Preview collection
  • Click the API Manifest button
  • Hit download and see a manifest downloaded to your device.

Notes

  • Get the correct manifest instructions from @RabebOthmani
  • Ensure items are localised

@thewahome thewahome requested review from ElinorW and Onokaev May 15, 2023 09:36
@thewahome thewahome force-pushed the feature/download-api-manifest branch from ab6ad8d to a415c32 Compare May 15, 2023 10:59
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

@thewahome thewahome linked an issue Nov 15, 2023 that may be closed by this pull request
Remove 'open in VS Code' button #2903
Closed
@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

2.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 27, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-2572.centralus.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Onokaev Onokaev Onokaev left review comments

@ElinorW ElinorW Awaiting requested review from ElinorW

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@thewahome @ElinorW @Onokaev @RabebOthmani