-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[User story] Copy API manifest path #2836
Comments
What is an API manifest path? |
@thewahome I'm noticing that what we are copying is an encoded value. Originally we encoded that to manage the URL and be able to open directly in VS Code. There's no need to encode anymore. Is there a use case for encoding? |
I am not sure @RabebOthmani . @baywet must we encode it for the VS Code extension to pick up the manifest? |
both would be supported I believe at this point. But To Rabeb's point, since we don't need to encode it anymore, having it copied to the clipboard not-encoded would be useful to people who want to copy it to do something else with it. |
Path generated
The generation
@thewahome @darrelmiller the requests are empty once we change the scope to Application and we are not capturing the app permissions required. This isn't the expected behaviour, is it? Please notice that changing the scope also changed the version of the API in the generation without the user changing it (admin beta is generated as V1) |
@RabebOthmani |
@darrelmiller GET/users is working, FYI @thewahome which means the conversation should be around the paths so we avoid such cases |
The faulty permissions are fixed now @RabebOthmani it's possible that @darrelmiller is looking at the updated values |
@baywet Could you please have a look on the VSCode integration? To be discussed. |
@thewahome is this in production or do you have a URI for a preview? |
It's still in staging. The repro steps are:
|
Thanks for the details. |
Just for clarity here: it's the "Paste API manifest" button that doesn't work properly (I can repro that). When you click on "Open in VS Code" in GE (which is what I was doing to date), it works properly. |
Update: I was able to isolate and fix the bug. However this is now going to consistently fail for both approaches because I also updated the api manifest dependency and the apiDeploymentBaseUrl generated by GE doesn't end with a trailing slash. Could you fix that last detail @thewahome please? |
(also application name now seems to be required by the spec) |
@baywet, I've added the trailing slash in the apiDeploymentBaseUrl property |
Thanks, do you have a staging URL for me to run integration tests? Or were you able to validate end to end with the latest preview of the vscode extension? |
As a user, when I click on the 'copy to clipboard' button
I want the API manifest path to be copied
So I can use it with the Kiota extension on VS Code
Acceptance criteria:
The text was updated successfully, but these errors were encountered: