Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zip][Portable] BurntSushi.ripgrep.GNU 13.0.0 #88067

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Nov 10, 2022

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@Trenly
Copy link
Contributor Author

Trenly commented Nov 10, 2022

@msftbot zip

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@ghost ghost added Needs-Author-Feedback This needs a response from the author. .zip Blocking-Issue Manifest validation is blocked by a known issue. labels Nov 10, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Nov 10, 2022
@ghost
Copy link

ghost commented Nov 10, 2022

Hello @Trenly,

The package manager bot determined that the metadata was not compliant.

Please verify the manifest file is compliant with the package manager 1.2 manifest specification.
Make sure the ID is of the form publisher.appname and that the folder structure is manifests\partition\publisher\appname\version.
Note: The path and "PackageIdentifier" are case sensitive.
Be sure to use a tool like VSCode to make sure the manifest YAML syntax is correct.

You could also try our Windows Package Manager Manifest Creator or the YamlCreate script.

For details on the specific error, see the details link below in the build pipeline.

Template: msftbot/validationError/manifest/metadata

ItzLevvie
ItzLevvie previously approved these changes Nov 10, 2022
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 10, 2022
@mdanish-kh mdanish-kh mentioned this pull request Jan 15, 2023
5 tasks
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

There was an error handling pipeline event ea7755b1-87b1-40fc-bdd5-db6a3c646a84.

@ghost ghost removed Manifest-Validation-Error Manifest validation failed Blocking-Issue Manifest validation is blocked by a known issue. Needs-Author-Feedback This needs a response from the author. Moderator-Approved One of the Moderators has reviewed and approved this PR labels Jan 31, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

There was an error handling pipeline event 0a5b5f56-5c1c-4597-a480-fb3f3ff8b706.

@Trenly
Copy link
Contributor Author

Trenly commented Jan 31, 2023

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jan 31, 2023
@ghost
Copy link

ghost commented Jan 31, 2023

Hello @Trenly,

The pull request encountered an internal error and has been assigned to a developer to investigate.

Template: msftbot/validationError/internalError

@ghost ghost added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 31, 2023
@ghost ghost assigned stephengillie and zachcarp Jan 31, 2023
@ghost ghost added the Retry-1 flag to indicate retried label Jan 31, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jan 31, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Jan 31, 2023
@ghost ghost assigned stephengillie and zachcarp Jan 31, 2023
@stephengillie
Copy link
Collaborator

@wingetbot waivers Add Validation-Executable-Error

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Validation-Completed Validation passed label Jan 31, 2023
@stephengillie stephengillie merged commit 0c8e510 into microsoft:master Feb 3, 2023
@Trenly Trenly deleted the zips/ripgrep-gnu branch February 3, 2023 18:21
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@adigitoleo
Copy link

adigitoleo commented Feb 24, 2023

Can't find the entry point on windows 11. Tried both GNU and MSVC installs. No 'rg', 'ripgrep' or similar, can't even see the directory in Program Files. Am I doing it wrong?

Edit: Found the directory, under Microsoft > WinGet > Packages. It is added to path but the problem is that the .exe resides in another level of nested directory and is not copied out of there.

@sitiom
Copy link
Contributor

sitiom commented Feb 25, 2023

Edit: Found the directory, under Microsoft > WinGet > Packages. It is added to path but the problem is that the .exe resides in another level of nested directory and is not copied out of there.

Workaround: Enable developer mode. Corresponding issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Retry-1 flag to indicate retried Validation-Completed Validation passed Validation-Executable-Error Waived-Validation-Executable-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants