Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria2.aria2 version v1.36.0 #93774

Closed
wants to merge 1 commit into from
Closed

aria2.aria2 version v1.36.0 #93774

wants to merge 1 commit into from

Conversation

neomax7
Copy link
Contributor

@neomax7 neomax7 commented Jan 15, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.2 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jan 15, 2023
@ghost
Copy link

ghost commented Jan 15, 2023

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jan 15, 2023

neomax7,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

Copy link
Contributor

@mdanish-kh mdanish-kh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Windows Package Manager policies requires that the InstallerUrl comes directly from the ISV's release location.

https://learn.microsoft.com/en-us/windows/package-manager/package/repository#error-labels

Please add Urls from the official source.

@ghost ghost added the Needs-Author-Feedback This needs a response from the author. label Jan 15, 2023
@ghost ghost assigned neomax7 Jan 15, 2023
@ghost
Copy link

ghost commented Jan 15, 2023

Hello @neomax7,

The package manager bot determined changes have been requested to your PR.

Template: msftbot/changesRequested

@neomax7
Copy link
Contributor Author

neomax7 commented Jan 15, 2023

The Windows Package Manager policies requires that the InstallerUrl comes directly from the ISV's release location.

https://learn.microsoft.com/en-us/windows/package-manager/package/repository#error-labels

Please add Urls from the official source.

original url only provide zip format. I believe providing it as an installer url wont work.

@ghost ghost added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 15, 2023
@mdanish-kh
Copy link
Contributor

You can add a PR for .zip installers using PRs #88065, #88067 as reference. As to when those PRs will get accepted, you can track the PSA #87300.

@neomax7
Copy link
Contributor Author

neomax7 commented Jan 15, 2023

You can add a PR for .zip installers using PRs #88065, #88067 as reference. As to when those PRs will get accepted, you can track the PSA #87300.

thank you :)

@neomax7 neomax7 closed this Jan 15, 2023
@neomax7 neomax7 deleted the autogenerated/aria2.aria2/9228c01b-6907-4eaa-a158-e694dba2b1d2 branch January 15, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants