Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UpgradeBehavior deny #3512

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Add UpgradeBehavior deny #3512

merged 5 commits into from
Aug 30, 2023

Conversation

Trenly
Copy link
Contributor

@Trenly Trenly commented Aug 8, 2023 •
edited by microsoft-github-policy-service bot
Loading

@Trenly Trenly requested a review from a team as a code owner August 8, 2023 22:03
@denelon
Copy link
Contributor

denelon commented Aug 8, 2023

We would have the work in the client and the schema here, as well as the REST schema and the docs at winget-pkgs.

@Trenly
Copy link
Contributor Author

Trenly commented Aug 15, 2023

cc @ryfu-msft

@yao-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

yao-msft
yao-msft previously approved these changes Aug 25, 2023
View reviewed changes
src/AppInstallerCLIPackage/Shared/Strings/en-us/winget.resw Outdated Show resolved Hide resolved
src/AppInstallerCLICore/Workflows/InstallFlow.cpp Outdated Show resolved Hide resolved
src/AppInstallerCLICore/Workflows/InstallFlow.cpp Outdated Show resolved Hide resolved
src/AppInstallerCLICore/Workflows/InstallFlow.cpp Outdated Show resolved Hide resolved
@yao-msft yao-msft dismissed their stale review August 26, 2023 01:22

e2e tests failed

@yao-msft
Copy link
Contributor

There are a couple e2e tests related to portable failed because of this new addition of portable 4.0.0.0 manifest with upgrade deny.

We should probably create a new package identifier (2 manifests) like AppInstallerTest.TestUpgradeDeny so it's isolated and not affecting other tests.

@Trenly
Copy link
Contributor Author

Trenly commented Aug 26, 2023

Makes sense; I'll take a look

@ryfu-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yao-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Trenly
Copy link
Contributor Author

Trenly commented Aug 29, 2023

@ryfu-msft - I took a look at the pester tests and I don't see any reason why the BuildPowerShellModule tests would be failing, especially when I didn't touch anything about the PowerShell modules or COM, and it seems like the pipelines are showing a COM error. Unless the changes to the SharedLib files are interfering somehow?

COMException: Failed to create instance: -2147023174

@ryfu-msft
Copy link
Contributor

@ryfu-msft - I took a look at the pester tests and I don't see any reason why the BuildPowerShellModule tests would be failing, especially when I didn't touch anything about the PowerShell modules or COM, and it seems like the pipelines are showing a COM error. Unless the changes to the SharedLib files are interfering somehow?

COMException: Failed to create instance: -2147023174

This seems like a transient error, lets see if the rerun fixes it. You must be lucky today 😄

@yao-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yao-msft yao-msft merged commit d0039d0 into microsoft:master Aug 30, 2023
8 checks passed
@Trenly Trenly deleted the DenyUpgrade branch August 30, 2023 01:37
@R-Adrian R-Adrian mentioned this pull request Oct 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yao-msft yao-msft yao-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trenly @denelon @yao-msft @ryfu-msft