Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Winget does not install all some updates #3510

Open
mwisnicki opened this issue Aug 7, 2023 · 3 comments
Open

Winget does not install all some updates #3510

mwisnicki opened this issue Aug 7, 2023 · 3 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.

Comments

@mwisnicki
Copy link

Brief description of your issue

Winget currently lists Chrome update and 2 vsredist updates however when I try running winget upgrade --all it will only install 1 package (one of vsredists), report success and then show that nothing was actually upgraded

Steps to reproduce

winget upgrade --all --verbose

Name                                                               Id                           Version        Available      Source
------------------------------------------------------------------------------------------------------------------------------------
Google Chrome                                                      Google.Chrome                115.0.5790.170 115.0.5790.171 winget
Microsoft Visual C++ 2010  x86 Redistributable - 10.0.30319        Microsoft.VCRedist.2010.x86  10.0.30319     10.0.40219     winget
Microsoft Visual C++ 2015-2022 Redistributable (x64) - 14.34.31931 Microsoft.VCRedist.2015+.x86 14.34.31931.0  14.36.32532.0  winget
3 upgrades available.
2 package(s) have version numbers that cannot be determined. Use --include-unknown to see all results.

(1/1) Found Microsoft Visual C++ 2015-2022 Redistributable (x86) [Microsoft.VCRedist.2015+.x86] Version 14.36.32532.0
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://download.visualstudio.microsoft.com/download/pr/eaab1f82-787d-4fd7-8c73-f782341a0c63/5365A927487945ECB040E143EA770ADBB296074ECE402
1B1D14213BDE538C490/VC_redist.x86.exe
  ██████████████████████████████  13.1 MB / 13.1 MB
Successfully verified installer hash
Starting package install...
Successfully installed

6 package(s) have version numbers that cannot be determined. Use --include-unknown to see all results.

winget upgrade

Expected behavior

All 3 packages are upgraded and all are recognized as updated

Actual behavior

Only 1 package is upgraded and then nothing is recognized as updated:

Name                                                               Id                           Version        Available      Source
------------------------------------------------------------------------------------------------------------------------------------
Google Chrome                                                      Google.Chrome                115.0.5790.170 115.0.5790.171 winget
Microsoft Visual C++ 2010  x86 Redistributable - 10.0.30319        Microsoft.VCRedist.2010.x86  10.0.30319     10.0.40219     winget
Microsoft Visual C++ 2015-2022 Redistributable (x64) - 14.34.31931 Microsoft.VCRedist.2015+.x86 14.34.31931.0  14.36.32532.0  winget
3 upgrades available.
2 package(s) have version numbers that cannot be determined. Use --include-unknown to see all results.

Environment

Windows Package Manager v1.5.1881
Copyright (c) Microsoft Corporation. All rights reserved.

Windows: Windows.Desktop v10.0.22621.1992
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.20.1881.0
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue need to be triaged label Aug 7, 2023
@Trenly
Copy link
Contributor

Trenly commented Aug 7, 2023

Google chrome uses it's own built-in updater to perform updates. Using winget to attempt an upgrade will only download and run the chrome installer, which detects chrome is already installed and exits.

The VCRedist's don't actually upgrade - they install Side-By-Side. These are being tracked through the issue below, and the Area-Matching Issue related to correlation between installed package and manifest label

@mwisnicki
Copy link
Author

Thanks for the explanation. 

As for Chrome, how come there is nothing logged in the output above?

@stephengillie stephengillie added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage Issue need to be triaged labels Aug 8, 2023
@Trenly
Copy link
Contributor

Trenly commented Aug 8, 2023

Thanks for the explanation. 

As for Chrome, how come there is nothing logged in the output above?

Because the installer returns exit code 0, which is indicative of a successful install. If the installer returned a custom error code, we would be able to use that to differentiate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

3 participants