Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add Tags and 'Filter with tag' option #189

Closed
Satanarious opened this issue Oct 3, 2022 · 15 comments
Closed

[Feature Request] Add Tags and 'Filter with tag' option #189

Satanarious opened this issue Oct 3, 2022 · 15 comments
Labels
new-feature A new feature that could be useful in WingetUI ready-to-go

Comments

@Satanarious
Copy link
Contributor

Satanarious commented Oct 3, 2022

Winget already has tags added to all its packages; it would be great If WingetUI would have a tag attached to each package in its description. Also, it would be helpful to filter packages by tags, which would need implementation. I think that won't be difficult to implement since Winget already has it and can filter packages with a given tag. I don't know about scoop though.

There's a problem though, where do we get all the tags from? I need to research that part.

@marticliment
Copy link
Owner

I don't know, but this might well end in a "search by category section" UI

@marticliment marticliment added new-feature A new feature that could be useful in WingetUI needs-further-study labels Oct 3, 2022
@ppvnf
Copy link
Contributor

ppvnf commented Oct 9, 2022

The tags are available on the package's manifest, example: https://github.com/microsoft/winget-pkgs/blob/master/manifests/y/YACReader/YACReader/9.9.1/YACReader.YACReader.locale.en-US.yaml

However, I believe winget show should display the tags, so I've opened an issue about this: microsoft/winget-cli#2585.

I've made a simple proof of concept about tags in the info menu:
Captura de tela 2022-10-09 095230

Also, I believe it would be interesting if you could click the tags and then be able to see other packages with the same tags in the search menu, like I've suggested here for the publisher's name: #219 (comment)

@ppvnf ppvnf mentioned this issue Oct 9, 2022
@Satanarious
Copy link
Contributor Author

Satanarious commented Oct 9, 2022

Please take a look at #209; tags should be done how the websites have done it, in a pill-shaped button. This will make the UI feel more intuitive.

Discord tags

Regarding the filtering part, since all package fetches are cli calls, winget-cli allows filtering by tags, publishers, etc.

Edit 1: Showing tags of a specific package will be added to winget-cli in the future; here's the issue related to it on winget's GitHub. The issue is marked as closed and done in their project to-dos but has yet to be released with winget-cli v1.4.

Edit 2: I looked into winget-cli releases, they released winget v1.4.2011-preview with the tags' issue solved in it. This release could be used to develop the tags feature and be added as soon as they release winget-cli v1.4

@Satanarious
Copy link
Contributor Author

@ppvnf, you can close your issue at winget-cli, since I mentioned in the former comment that it was already created, closed, and released in a preview build.

@ppvnf
Copy link
Contributor

ppvnf commented Oct 9, 2022

Please take a look at #209; tags should be done how the websites have done it, in a pill-shaped button. This will make the UI feel more intuitive.

I agree. You mean something like this, right?

Captura de tela 2022-10-09 095230

Regarding the filtering part, since all package fetches are cli calls, winget-cli allows filtering by tags, publishers, etc.

I know filtering packages using tags is possible with winget search --tag. For publisher/description maybe search using the data already fetched by WingetUI. However, I think we should discuss it at #223 (comment)

Edit 1: Showing tags of a specific package will be added to winget-cli in the future; here's the issue related to it on winget's GitHub. The issue is marked as closed and done in their project to-dos but has yet to be released with winget-cli v1.4.

Edit 2: I looked into winget-cli releases, they released winget v1.4.2011-preview with the tags' issue solved in it. This release could be used to develop the tags feature and be added as soon as they release winget-cli v1.4

Thanks, It's good to know this is gonna be implemented soon!

@marticliment
Copy link
Owner

However, while we can get tags by analyzing each package, the main issue is how to bulk-load all tags when running 'winger search', without having to iterate through every single package with winget show, because that would be impossible

@Satanarious
Copy link
Contributor Author

However, while we can get tags by analyzing each package, the main issue is how to bulk-load all tags when running 'winger search', without having to iterate through every single package with winget show, because that would be impossible

Don't bulk-load all tags, but only load tags for a package when its popup is opened

@ppvnf
Copy link
Contributor

ppvnf commented Oct 9, 2022

Don't bulk-load all tags, but only load tags for a package when its popup is opened

Yes, as you said, this is possible in Winget v1.4.2011-preview.

And searching with tags should simply display the results of winget search --tag "name of the tag"

@ppvnf
Copy link
Contributor

ppvnf commented Oct 10, 2022

@martinet101 I've installed Winget v1.4.2161-preview to confirm that it's possible to use winget show to see the package tags:

Captura de tela 2022-10-10 180547

@Satanarious
Copy link
Contributor Author

Try using,
winget show <Package Name> -tag
winget show <Package Name> -t
the originally proposed command to show tags for a package

See if this works.

@ppvnf
Copy link
Contributor

ppvnf commented Oct 10, 2022

Try using, winget show <Package Name> -tag winget show <Package Name> -t the originally proposed command to show tags for a package

See if this works.

It doesn't work, maybe they forgot to add it. I'm gonna comment about it here: microsoft/winget-cli#2235

Captura de tela 2022-10-10 182907

Edit: See explanation why this is not possible: microsoft/winget-cli#2235 (comment)
However, as I've said in #189 (comment), winget show without parameters shows tags in v. 1.4

@ppvnf
Copy link
Contributor

ppvnf commented Feb 19, 2023

I believe implementing this is possible with Winget 1.4 even without the winget.run-api

@marticliment
Copy link
Owner

Yes, it is now.

I am just waiting to finish implementing the winget COM api component (see #712)

@ppvnf
Copy link
Contributor

ppvnf commented Apr 15, 2023

Chocolatey also supports tags by the way

@marticliment
Copy link
Owner

image
For the time being, filter with tags won't be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature A new feature that could be useful in WingetUI ready-to-go
Projects
None yet
Development

No branches or pull requests

3 participants