-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve version parsing to better support "preambles" #2394
Comments
Related to #1298 |
What's the tipping point for this issue to be solved ? |
There seems to be no mechanism to handle beta/release candidate, etc. version numbering, which leaves the users at the hands of however winget interprets the version number. This could lead to false 'upgrades'. |
That's correct, we still have a big chunk of work left in order to handle channels. |
- [x] This pull request is related to an issue. - #2394
Resolved by #4558 |
Description of the new feature / enhancement
The version parsing could be improved to ignore leading, non-numeric values that are then followed by a more normal version number. This would apply to versions like
v1.2.3
, as well as the package detailed in microsoft/winget-pkgs#67794For example
ad 7.0.13
would equal7.0.13
andv1.2.3
would equal1.2.3
.foo1
would equalbar1
, but1.foo2
would not equal1.bar2
, as only leading non-numeric characters would be ignored.Proposed technical implementation details
For the first version part (where parts are split by the
.
character), determine if there is a number at the end (currently only decimal integers are supported) and use it as the integer portion. Do not use the "preamble" in the version at all.The text was updated successfully, but these errors were encountered: