Skip to content

[Package Issue]: o2sh.onefetch #90267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
russellbanks opened this issue Dec 1, 2022 · 4 comments
Closed
2 tasks done

[Package Issue]: o2sh.onefetch #90267

russellbanks opened this issue Dec 1, 2022 · 4 comments
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone

Comments

@russellbanks
Copy link
Contributor

russellbanks commented Dec 1, 2022

Please confirm these before moving forward

  • I have searched for my issue and not found a work-in-progress/duplicate/resolved issue.
  • I have not been informed if the issue is resolved in a preview version of the winget client.

Category of the issue

Other

Brief description of your issue

Onefetch 2.13.0, 2,13,1 & 2,13,2 wrote "v" in its DisplayVersion. It removed this in 2.14.0+. The ARP Entries are correctly set in each manifest (2.13.x has the DisplayVersion ARP of vx.x.x while 2.14.x does not). WinGet sees this as below:

> winget upgrade
Name                                                       Id                          Version      Available    Source
-----------------------------------------------------------------------------------------------------------------------
onefetch version 2.14.2                                    o2sh.onefetch               > 2.13.2     2.14.2       winget

I know this is a known issue, but I want to know the best way to fix this case. I opened #90263, #90264, #90265 to remove the manifests that refer to the versions that have the "v" in their DisplayVersion as I imagine this would fix it. Other mods might have better suggestions though.

Steps to reproduce

winget install onefetch

cc: @mdanish-kh

@russellbanks russellbanks added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Dec 1, 2022
@ghost ghost added the Needs-Triage This work item needs to be triaged by a member of the core team. label Dec 1, 2022
@stephengillie stephengillie removed the Needs-Triage This work item needs to be triaged by a member of the core team. label Dec 1, 2022
@stephengillie
Copy link
Collaborator

stephengillie commented Dec 1, 2022

#2394

@russellbanks
Copy link
Contributor Author

#2394

Would my PRs fix this temporarily?

@Trenly
Copy link
Contributor

Trenly commented Dec 2, 2022

#2394

Would my PRs fix this temporarily?

Yes, removing the versions would work temporarily

@russellbanks
Copy link
Contributor Author

Closing as resolved until microsoft/winget-cli#1298 and microsoft/winget-cli#2394 are addressed.

@denelon denelon added this to the 1.7 Packages milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

No branches or pull requests

4 participants