-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git status representation in the explorer viewlet implemented #8462
Conversation
Unfortunately I cannot accept this PR as such because it introduces a dependency from files land to git land. Logically files land should not be aware of git land but rather we should have extension points that allow us to modify the colors and possibly icons in the explorer from the outside. This would maybe also allow extensions to do this. |
@bpasero If I got you right then we could do the following: the interface in use could be e.g. interface FileRendererDecorator {
decorateItem(tree: ITree, stat: FileStat, explorerItemLabel: HTMLElement) : void
} perhaps this could even be used to support icons in the explorer. |
Yes, we need a registry where other components can participate in decorating explorer items. I actually think this should be generic enough for any tree we have and not just the explorer. Trees can then opt in to decide if they want to participate in decorations or not and the explorer could be the first one of those. Have not yet thought about how the API (both internal and possibly external could look like). Maybe we open a discussion issue first? |
@bpasero Good idea, please open a discussion issue when you have some time 👍 |
5a029b1
to
29bbc55
Compare
@bpasero I've updated the implementation according to what we have discussed, please have a look |
Thanks, since it is currently endgame, expect no reply until July milestone 👍 |
29bbc55
to
7cf410d
Compare
A first example is also included: gitStatusTreeDecorator Resolves microsoft#5866 Related microsoft#211
7cf410d
to
b47ebd3
Compare
Adding @joaomoreno because this PR touches a lot in tree and git land. |
Oh yes please!! As soon as possible!! |
I think there are a few shortcomings with the current approach:
Given that I am tempted to close this issue. It needs proper planning, architecture and most of all: time. |
Resolves #5866