chore: Upgrade to electron 7.x #83796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
force-pushed
the
electron-7.0.x
branch
5 times, most recently
from
8b1d30d to
5a658f0
Compare
bpasero
approved these changes
Nov 2, 2019
There was a problem hiding this comment.
Changes LGTM but I suggest this timeline:
- consistent green CI builds on all platforms
- green exploration build for selfhosting during this milestone
- full endgame testing on all platforms on exploration build (including dev setup)
- push to insiders next milestone if no blockers
ZuBB
reviewed
Nov 4, 2019
| @@ -366,15 +366,13 @@ export class ElectronMainService implements IElectronMainService { | |||
| //#region Connectivity | |||
|
|
|||
| async resolveProxy(windowId: number | undefined, url: string): Promise<string | undefined> { | |||
There was a problem hiding this comment.
(maybe I am missing smth, but still..) Is current version of return type still valid after change that is below?
deepak1556
force-pushed
the
electron-7.0.x
branch
from
5a658f0 to
a764ec4
Compare
This was referenced Nov 7, 2019
deepak1556
force-pushed
the
electron-7.0.x
branch
2 times, most recently
from
fbad8db to
d3f8859
Compare
68 tasks
deepak1556
force-pushed
the
electron-7.0.x
branch
4 times, most recently
from
2c46e2a to
f8d2758
Compare
deepak1556
force-pushed
the
electron-7.0.x
branch
from
f8d2758 to
20ab677
Compare
21 tasks
deepak1556
force-pushed
the
electron-7.0.x
branch
from
20ab677 to
22c3db0
Compare
|
What prevents this to be merged? It is required for linux accessibility so I am waiting impatiently... |
mjbvz
reviewed
Jan 9, 2020
| @@ -13,7 +13,7 @@ const webviewId = 'myWebview'; | |||
|
|
|||
| const testDocument = join(vscode.workspace.rootPath || '', './bower.json'); | |||
|
|
|||
| suite('Webview tests', () => { | |||
| suite.skip('Webview tests', () => { | |||
There was a problem hiding this comment.
Hey looks like web views are broken under electron due to Prevented webview attach. I'm looking into it but wonder if you have any idea what that may be?
There was a problem hiding this comment.
Pushed fix with c8123de and re-enabled the tests
mjbvz
added a commit
that referenced
this pull request
Jan 9, 2020
Caused by #83796 Also re-enables the webview tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromium: 78.0.3904.130
Nodejs: 12.8.1
Electron: 7.1.7