Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Electron 7: failing test (window namespace tests active editor not always correct) #87330

Closed
bpasero opened this issue Dec 19, 2019 · 1 comment
Closed

Electron 7: failing test (window namespace tests active editor not always correct) #87330

bpasero opened this issue Dec 19, 2019 · 1 comment
Assignees
@bpasero @deepak1556
Labels
integration-test-failure macos Issues with VS Code on MAC/OS X remote Remote system operations issues
Milestone
February 2020

Comments

@bpasero
Copy link
Member

bpasero commented Dec 19, 2019 •
edited
Loading

This started to fail recently with updating to latest Electron 7 on macOS only (build failure):

1) window namespace tests active editor not always correct... #49125:

      AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert(vscode_1.window.activeTextEditor === editorA)

      + expected - actual

      -false
      +true
      
      at Context.<anonymous> (/Users/runner/runners/2.163.1/work/1/s/extensions/vscode-api-tests/src/singlefolder-tests/window.test.ts:155:4)
      at processTicksAndRejections (internal/process/task_queues.js:89:5)
@bpasero bpasero added this to the December/January 2020 milestone Dec 19, 2019
@bpasero bpasero added the macos Issues with VS Code on MAC/OS X label Dec 19, 2019
@bpasero
Copy link
Member Author

bpasero commented Dec 19, 2019

This seems to be the remote integration tests [1], not normal ones. Though I cannot reproduce...

[1] ./resources/server/test/test-remote-integration.sh

@bpasero bpasero added the remote Remote system operations issues label Dec 19, 2019
deepak1556 added a commit that referenced this issue Jan 9, 2020
@deepak1556
skip test for #87330
59d4924
deepak1556 added a commit that referenced this issue Jan 9, 2020
@deepak1556 @bpasero
chore: Upgrade to electron 7.x (#83796)
4c7431c 
* chore: bump [email protected]

* chore: update api

* chore: Bump [email protected]

* chore: bump [email protected]

* chore: Bump [email protected]

* chore: Bump [email protected]

* FIXME: Skip webview tests that have improper shutdown path

* chore: Bump [email protected]

* bump [email protected]

* debug test failures

* chore: bump [email protected]

* skip test for #87330

Co-authored-by: Benjamin Pasero <[email protected]>
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@deepak1556 deepak1556

Labels
integration-test-failure macos Issues with VS Code on MAC/OS X remote Remote system operations issues
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
2 participants
@bpasero @deepak1556