Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workbench: Adds 'Show Code Version' Action #40745

Merged
merged 1 commit into from
Feb 9, 2018
Merged

workbench: Adds 'Show Code Version' Action #40745

merged 1 commit into from
Feb 9, 2018

Conversation

shobhitchittora
Copy link
Contributor

Fixes: #40574

@shobhitchittora shobhitchittora mentioned this pull request Dec 23, 2017
Closed
@shobhitchittora
Copy link
Contributor Author

shobhitchittora commented Dec 23, 2017 •
edited
Loading

@joaomoreno Please review this 😇.

@weinand weinand requested a review from bpasero December 23, 2017 09:52
@weinand weinand requested review from joaomoreno and removed request for bpasero December 23, 2017 09:53
@bpasero
Copy link
Member

bpasero commented Dec 23, 2017

@shobhitchittora can I ask, why not simply show the about dialog that includes the version?

@shobhitchittora
Copy link
Contributor Author

This is as per suggestion from @joaomoreno in the issue thread. Also I think here the intent is just show version number and not any additional info, thus adding as a Command.

@bpasero
Copy link
Member

bpasero commented Dec 27, 2017

@shobhitchittora @joaomoreno I would prefer a command that simply shows the about dialog

@shobhitchittora
Copy link
Contributor Author

shobhitchittora commented Dec 28, 2017 •
edited
Loading

@joaomoreno @bpasero I found the below function which open the About dialog from menu bar items.
https://github.com/Microsoft/vscode/blob/c5669a2520f3fc2cb7a0ecb97c47cdd2de4f9d33/src/vs/code/electron-main/menus.ts#L1201
Is it possible to invoke this by registering a new Action in the registry?

@bpasero bpasero assigned joaomoreno and unassigned bpasero Dec 28, 2017
@shobhitchittora
Copy link
Contributor Author

Ping @joaomoreno . Any follow-ups on this?

@joaomoreno joaomoreno added this to the Backlog milestone Jan 8, 2018
@bpasero bpasero removed the workbench label Jan 11, 2018
@joaomoreno joaomoreno modified the milestones: Backlog, February 2018 Feb 9, 2018
@joaomoreno joaomoreno merged commit 368785b into microsoft:master Feb 9, 2018
@joaomoreno
Copy link
Member

@shobhitchittora Thanks for the contribution! 🍻

Sorry for not getting back earlier. I've renamed the command to Help: About. I've moved it to another contribution file. I've also changed the implementation to what @bpasero suggested.

@shobhitchittora
Copy link
Contributor Author

Awesome ✌️

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno Awaiting requested review from joaomoreno

Assignees

@joaomoreno joaomoreno

Labels
None yet
Projects
None yet
Milestone
February 2018
Development

Successfully merging this pull request may close these issues.

Have a global command which triggers the About dialog, or shows version information
3 participants
@shobhitchittora @bpasero @joaomoreno