Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have a global command which triggers the About dialog, or shows version information #40574

Closed
thibran opened this issue Dec 20, 2017 · 3 comments · Fixed by #40745
Closed

Have a global command which triggers the About dialog, or shows version information #40574

thibran opened this issue Dec 20, 2017 · 3 comments · Fixed by #40745
Assignees
@joaomoreno
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities workbench-diagnostics General VS Code built-in diagnostic issues
Milestone
Backlog

Comments

@thibran
Copy link

thibran commented Dec 20, 2017

  • VSCode Version: 1.19.0
  • OS Version: openSUSE Tumbleweed (Linux)

Steps to Reproduce:

  1. press Ctrl+Shift+P
  2. enter "version"
  3. results in no entry, but should

As enhancement it would be nice if the show-all-command would have an entry to display the Visual Studio Code version (I know that I could pass the --version flag on the command-line).

Such a feature exists e.g. in Emacs, where it is possible to enter M-x version and get the current Emacs version displayed.
@Tyriar Tyriar assigned joaomoreno and unassigned Tyriar Dec 20, 2017
@Tyriar Tyriar added the feature-request Request for new features or functionality label Dec 20, 2017
@joaomoreno joaomoreno changed the title no version entry when using show-all-command Have a global command which triggers the About dialog, or shows version information Dec 21, 2017
@joaomoreno joaomoreno added this to the Backlog milestone Dec 21, 2017
@joaomoreno joaomoreno added the help wanted Issues identified as good community contribution opportunities label Dec 21, 2017
@shobhitchittora
Copy link
Contributor

shobhitchittora commented Dec 21, 2017 •
edited
Loading

@joaomoreno I'd like to take this up. Any pointers? 😇

  1. So far I though to extend the current Shell Command
    https://github.com/Microsoft/vscode/blob/30be0469d40c54794e5450a230c5e5cbc2bf9811/src/vs/workbench/parts/cli/electron-browser/cli.contribution.ts#L31
  2. How to execute code --version and show the result? Or is there a place where we store version globally?
  3. Can we open up the Output panel and show the result of code --version there?

@joaomoreno
Copy link
Member

No need to execute code --version, that information can be obtained by requiring vs/platform/node/package. Output is good, but a message box is better.

@shobhitchittora shobhitchittora mentioned this issue Dec 23, 2017
Merged
@shobhitchittora
Copy link
Contributor

shobhitchittora commented Dec 23, 2017 •
edited
Loading

@joaomoreno raised a PR #40745 . Currently added in the action under Shell Command. Any better section to add this in?

@bpasero bpasero added workbench-diagnostics General VS Code built-in diagnostic issues and removed workbench labels Jan 12, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities workbench-diagnostics General VS Code built-in diagnostic issues
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

workbench: Adds 'Show Code Version' Action shobhitchittora/vscode
5 participants
@joaomoreno @bpasero @Tyriar @shobhitchittora @thibran