Skip to content

fix one off error for chat edits and checkpoints #274254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix one off error for chat edits and checkpoints #274254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingCheckpointTimelineImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ export class ChatEditingCheckpointTimelineImpl implements IChatEditingCheckpoint
throw new Error(`Checkpoint ${checkpointId} not found`);
}

return this._navigateToEpoch(targetCheckpoint.epoch + 1);
Copy link
Member

@connor4312 connor4312 Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should have been good as-is. Having _currentEpoch === thing.epoch means 'thing' hasn't happened yet.

return this._navigateToEpoch(targetCheckpoint.epoch);
}

public getContentURIAtStop(requestId: string, fileURI: URI, stopId: string | undefined): URI {
Expand Down
Loading