fix one off error for chat edits and checkpoints #274254
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the checkpoint navigation logic where navigating to a checkpoint was incorrectly setting the current epoch to one past the target checkpoint's epoch, causing the checkpoint to not be applied.
Key change:
- Corrected the epoch calculation in
navigateToCheckpointto align with the system's invariant that_currentEpochequal to a checkpoint's epoch means the checkpoint is applied.
connor4312
reviewed
Oct 31, 2025
| throw new Error(`Checkpoint ${checkpointId} not found`); | ||
| } | ||
|
|
||
| return this._navigateToEpoch(targetCheckpoint.epoch + 1); |
There was a problem hiding this comment.
This line should have been good as-is. Having _currentEpoch === thing.epoch means 'thing' hasn't happened yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #274084