Skip to content

Fix SessionViewPane leaks #274239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 3, 2025
Merged

Fix SessionViewPane leaks #274239

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
38f5c83
Prevent ChatEditorInput leak
Oct 30, 2025
92ecb67
Few minor updates
Oct 30, 2025
3d19438
Revert "Few minor updates"
Oct 30, 2025
9f55f34
Revert "Prevent ChatEditorInput leak"
Oct 30, 2025
8f28f6a
Merge branch 'microsoft:main' into main
vijayupadya Oct 30, 2025
496391c
Fix sessionViewPane leak
Oct 31, 2025
7ea3c53
Merge branch 'main' into vijayu/leak_Fix3_273039
vijayupadya Oct 31, 2025
1d91886
Merge branch 'main' into vijayu/leak_Fix3_273039
vijayupadya Nov 3, 2025
f595893
Simplification based on PR feedback
Nov 3, 2025
61a30f4
Merge branch 'vijayu/leak_Fix3_273039' of https://github.com/vijayupa…
Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions src/vs/workbench/contrib/chat/browser/chatSessions/view/sessionsViewPane.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { $, append } from '../../../../../../base/browser/dom.js';
import { IActionViewItem } from '../../../../../../base/browser/ui/actionbar/actionbar.js';
import { IBaseActionViewItemOptions } from '../../../../../../base/browser/ui/actionbar/actionViewItems.js';
import { ITreeContextMenuEvent } from '../../../../../../base/browser/ui/tree/tree.js';
import { Action, IAction } from '../../../../../../base/common/actions.js';
import { IAction, toAction } from '../../../../../../base/common/actions.js';
import { coalesce } from '../../../../../../base/common/arrays.js';
import { Codicon } from '../../../../../../base/common/codicons.js';
import { FuzzyScore } from '../../../../../../base/common/filters.js';
Expand Down Expand Up @@ -143,9 +143,7 @@ export class SessionsViewPane extends ViewPane {
icon: Codicon.plus,
}, undefined, undefined, undefined, undefined);

const menu = this.menuService.createMenu(MenuId.ChatSessionsMenu, this.scopedContextKeyService);

const actions = menu.getActions({ shouldForwardArgs: true });
const actions = this.menuService.getMenuActions(MenuId.ChatSessionsMenu, this.scopedContextKeyService, { shouldForwardArgs: true });
const primaryActions = getActionBarActions(
actions,
'submenu',
Expand All @@ -165,12 +163,12 @@ export class SessionsViewPane extends ViewPane {
return;
}

const dropdownAction = new Action(
'selectNewChatSessionOption',
nls.localize('chatSession.selectOption', 'More...'),
'codicon-chevron-down',
true
);
const dropdownAction = toAction({
id: 'selectNewChatSessionOption',
label: nls.localize('chatSession.selectOption', 'More...'),
class: 'codicon-chevron-down',
run: () => { }
});

const dropdownActions: IAction[] = [];

Expand Down
Loading