Fix SessionViewPane leaks #274239
Merged
Fix SessionViewPane leaks #274239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a memory leak in the chat sessions view by properly disposing of resources created when action view items are recreated. When the toolbar recreates action items, the previous menu and dropdownAction instances were not being disposed, leading to potential memory leaks.
Key Changes
- Adds a
DisposableStoreto track disposables for the chat session dropdown - Clears previous disposables before creating new action view items
- Registers the menu and dropdown action with the disposable store
src/vs/workbench/contrib/chat/browser/chatSessions/view/sessionsViewPane.ts
Show resolved
Hide resolved
mjbvz
reviewed
Nov 3, 2025
| 'codicon-chevron-down', | ||
| true | ||
| ); | ||
| this._dropdownDisposables.add(dropdownAction); |
There was a problem hiding this comment.
Can dropdownAction be converted to use toAction instead? That version of IAction isn't disposable
src/vs/workbench/contrib/chat/browser/chatSessions/view/sessionsViewPane.ts
Outdated
Show resolved
Hide resolved
added 2 commits
November 3, 2025 11:26
mjbvz
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #274236
The getChatSessionDropdown method created disposable objects (dropdownAction Action and menu IMenu) that were never registered with a parent or explicitly disposed. These orphaned disposables were passed to DropdownWithPrimaryActionViewItem but the view item doesn't take ownership, causing them to leak.