Defer updating screen reader content when no in a11y mode #163677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before TextAreaHandler.onCursorStateChanged was taking approximately 4-16% of the total keypress task's runtime. After this is becomes < 0.5ms. Part of #161622
alexdima
requested changes
Oct 17, 2022
alexdima
approved these changes
Oct 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
TextAreaHandler.onCursorStateChangedwas taking approximately 4-16% of the total keypress task's runtime (it varies pretty wildly). After this is becomes < 0.5msPart of #161622
Testing methodology outlined in #161622 (comment)
Before:
After:
@alexdima anything in particular I should test here? The behavior should be the same when a11y mode is on and text input seems to work fine when it's off.