-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Measure input latency and text render time #163184
Conversation
@alexdima thoughts on the approach? Probably won't merge this for October as time is a bit tight and I'd want to see if anything goes wrong in Insiders first |
@Tyriar Let's look at this next debt week. |
@alexdima I'll be out all next week fyi, but can meet or react to comments the first week of dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea. Some high level comments:
- IMHO we should move away from using the browser's
performance
and do the math on our won. - We don't need a buffer, we can compute a rolling average by adding things up at each moment and dividing at the end (i.e. each data structure needs to keep
min
,max
,avgSum
andavgCount
). Then there is no need to allocate memory or loop over items or worry about overflows.
… the browser does layout and painting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Telemetry side of things looks good to me 👍. Do we plan to collect this indefinitely?
@lramos15 yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @alexdima 👍
WIP - This may not get merged
Part of #161622