Emmet Wrap with Abbreviation History, fixes #40096 #114170
Conversation
rzhao271
added
feature-request
There was a problem hiding this comment.
I did not test this yet, but I wonder how it performs when compared to something simpler like the commit message box history. I think we should aim for something light still and I could imagine after several emmet usages, the list could get long and cluttered making basic emmet usage more cumbersome. I know we cannot use an input box with history from an extension but the spirit remains.
| * Both successful (accepted) and non-successful (cancelled) expansion attempts are stored. | ||
| * The expansion attempts are stored per extension reload. | ||
| */ | ||
| let previousItems: Set<string> = new Set(); |
There was a problem hiding this comment.
could be const if you don't recreate
There was a problem hiding this comment.
should this be initialized from previous sessions. e.g. if I press up in the commit message box, i can see commit messages from long ago
There was a problem hiding this comment.
I think that can go into a separate feature, since firstly, I'd have to look into where to write the abbreviation history to, and secondly, I'd probably need to add a "clear history" command.
| previousItems.add(valueToUse); | ||
| resolve(valueToUse); | ||
| } else { | ||
| resolve(''); |
There was a problem hiding this comment.
The value is passed to makeChanges, and both undefined and '' would do the same thing in this case.
rzhao271
force-pushed
the
rzhao271/wwa-history
branch
from
0376024 to
b52667f
Compare
Just tested -- the quickpick comes with a scrollbar, so it isn't too bad. |
rzhao271
force-pushed
the
rzhao271/wwa-history
branch
from
11a683d to
29fed26
Compare
rzhao271
dismissed
sbatten’s stale review
Added response as comment, also testing this GitHub feature
rzhao271
force-pushed
the
rzhao271/wwa-history
branch
from
29fed26 to
a569ac3
Compare
|
Discussed offline with @sbatten |
This PR fixes #40096 by replacing the inputbox that shows up during
Wrap with Abbreviationwith a quickpick.