Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap with abbreviation history #40096

Open
benlane opened this issue Dec 12, 2017 · 9 comments
Open

Wrap with abbreviation history #40096

benlane opened this issue Dec 12, 2017 · 9 comments
Assignees
Labels
emmet Emmet related issues feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Milestone

Comments

@benlane
Copy link

benlane commented Dec 12, 2017

Coming from atom this is a feature that i miss.

When wrapping with abbreviation you could use the up and down arrows to go through previously used abbreviations.

So if you had created a long abbreviation and it was slightly wrong or you wanted to reuse you wouldn't have to type it out all over again.

@vscodebot vscodebot bot added the editor label Dec 12, 2017
@ramya-rao-a
Copy link
Contributor

That's a great feature.
PRs are welcome.
I can guide anyone who wants to take this up.
https://github.com/Microsoft/vscode/blob/release/1.19/extensions/emmet/src/abbreviationActions.ts#L32 is where to start.

@ramya-rao-a ramya-rao-a added emmet Emmet related issues help wanted Issues identified as good community contribution opportunities feature-request Request for new features or functionality and removed editor labels Dec 12, 2017
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Dec 12, 2017
@shobhitchittora
Copy link
Contributor

Hi @ramya-rao-a,
I'd like to work on this. It'd be great if you could explain the issue in more detail, with some steps to reproduce.

Thanks.

@ramya-rao-a
Copy link
Contributor

I think I spoke too soon.
We have a control to take user typed input. (vscode.window.showInputBox)
We have a control to take user input from given array of choices. (vscode.window.showQuickPick)
For this feature, we would need both.
An array of choices to choose from, and to type in a value that is not in the array.

AFAIK we dont have a control that can do this.
@bpasero Can you confirm?

@pfongkye
Copy link
Contributor

Hi @shobhitchittora
I could take a look at this issue if you're not working on it.
Lemme know.
Thanks

@shobhitchittora
Copy link
Contributor

@pfongkye Go ahead. 👍

@Hlusta
Copy link

Hlusta commented Mar 5, 2020

Is there any progress with this? Thx!

@pfongkye
Copy link
Contributor

pfongkye commented May 1, 2020

Hello @Hlusta ,
sorry for the late reply. I haven't had time working on this. You're welcome to take it if you wish unless someone else already has.

@rzhao271
Copy link
Contributor

This task currently depends on extensions being able to display inputboxes (not sure if quick-input) with history. @TylerLeonhardt I'm wondering if there's already an issue to track that feature?

@TylerLeonhardt
Copy link
Member

@rzhao271 Yes that's #18232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emmet Emmet related issues feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants