Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sql] add support for mysql #5223

Closed
llewelynrex opened this issue Apr 13, 2016 · 4 comments
Closed

[sql] add support for mysql #5223

llewelynrex opened this issue Apr 13, 2016 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality languages-basic Basic language support issues
Milestone

Comments

@llewelynrex
Copy link

  • VSCode Version: 0.10.11
  • OS Version: Windows 7 Professional

Steps to Reproduce:

I have a \ character defined as a string in an update query. The Syntax highlighting is incorrectly escaping the following ' and displaying the rest of the script as a string. I am using UTF-8 Encoding with SQL as the language. Below two screenshots:

error

This is the same piece of script in SSMS.
ssms

@aharpervc
Copy link

Possibly related: atom/language-sql#13 (probably using the same grammars?). Whoever fixes it first should send a patch to the other, if so.

@aeschli aeschli added the feature-request Request for new features or functionality label Apr 22, 2016
@aeschli aeschli added this to the Backlog milestone Apr 22, 2016
@aeschli aeschli added the languages-basic Basic language support issues label Apr 22, 2016
@aeschli aeschli changed the title SQL Syntax Highlighting error [sql] add support for mysql Apr 22, 2016
@aeschli
Copy link
Contributor

aeschli commented Apr 22, 2016

We're using https://github.com/textmate/sql.tmbundle.
From the discussion in atom/language-sql#13 it looks like this is about different dialects of SQL. You seem to use the MySQL dialect, where '' is not an escape character.
Just removing it wouldn't work, as it would break other users.
I guess we need to add separate language support for MySQL.

@aharpervc
Copy link

This isn't a MySQL thing, even though the OP described it that way, or otherwise stated, it is also a SQL Server syntax issue. In any case, separate sql dialects probably need separate rules. There is also the question of what the default should be.

@aeschli
Copy link
Contributor

aeschli commented Nov 22, 2017

This got fixed in the meantime, likely by the switch of the SQL grammar from https://github.com/Microsoft/vscode-mssql

@aeschli aeschli closed this as completed Nov 22, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality languages-basic Basic language support issues
Projects
None yet
Development

No branches or pull requests

3 participants