'Peek Definition' missing from context menu

[gjsjohnmurray]

Issue Type: Bug

VS Code version: Code - Insiders 1.41.0-insider (bd8425f, 2019-11-20T09:17:36.311Z)
OS version: Windows_NT x64 10.0.17763

The keyboard equivalent (Alt+F12 on Windows) does still work.

On 1.40.1 it is there:

[jrieken]

We have done that on purpose in an effort to cleanup the context menu. All peek-commands are still there, e.g accessible via keybindings or via the command palette but we redesign the context menu like this... Two options that I see

1. Add another group to the context menu which contains peek commands, like Peek Definition, Peek Declaration, Peek Implementation, Peek References,
2. Toggle commands when holding alt, similar to editor title actions, e.g hold alt while the menu shows goto-commands would turn them into their alternative peek-commands

Personally, I'd prefer option 2 because it will keep the context menu small and gives all the power, however at the cost of being harder to discover.

[edit] screen capture of how this works on the Mac

[jrieken]

For completeness - this has been mentioned before here: #83752 (comment)

[gjsjohnmurray]

How about grouping them all on a "Peek" submenu? That'd make them discoverable to folk who rely on right-click to find out what they can do on things (as opposed to reading the doc).

[gjsjohnmurray]

Maybe this case can get some activity underway on #9827 🙏

[jrieken]

Yeah, it would require to implement sub menus. I'll do some exploring

[jrieken]

I have pushed this to master

[gjsjohnmurray]

I like this. Just wondering why the sequence of "Peek" options differs from the sequence of "Go to" options.

[jrieken]

The order should now be the same... Anyways, we aren't sold on the sub menu approach yet. There are concerns about this being too noisy and therefore some questions why you have missed "Peek Definition".

• Is that something you simply noticed?
• Is that something you use (regular/rare) but only through the context menu and not via keybinding or F1?
• Is this the only peek command that you are missing?

[jrieken]

We will stick with the sub context menu for now.