Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alt property of a context menu item contributed by an extension has no effect #86591

Closed
gjsjohnmurray opened this issue Dec 9, 2019 · 5 comments
Labels
feature-request Request for new features or functionality menus Menu items and widget issues

Comments

@gjsjohnmurray
Copy link
Contributor

Issue Type: Bug

Based on c0caab4 and #85218 (comment) I expected to be able to add an alt property to entries that my extension's package.json contributes to the editor/context menu

        "menus": {
            "editor/context": [
                {
                    "command": "thefoldingstuff.fold",
                    "alt": "thefoldingstuff.foldRecursively",
                    "title": "Fold",
                    "group": "thefoldingstuff"
                },
                {
                    "command": "thefoldingstuff.unfold",
                    "alt": "thefoldingstuff.unfoldRecursively",
                    "title": "Unfold",
                    "group": "thefoldingstuff"
                },

But when I run my extension the command invoked from my entries in the context menu is always the one specified in the command property, even if I hold down the Alt key when picking the option.

VS Code version: Code - Insiders 1.41.0-insider (87c2e0b, 2019-12-06T21:36:11.793Z)
OS version: Windows_NT x64 10.0.18363

@sbatten
Copy link
Member

sbatten commented Dec 9, 2019

The alt key is not something that can be pressed with Windows native context menus.

macOS: allows option + click in context menu
windows: allows alt + click in context menu with custom (not native)
linux: allows alt + click in context menu

So, yes, we could theoretically support this, but since it is a foreign concept to native windows, I'm not super sure we should.

/cc @bpasero

@sbatten sbatten added feature-request Request for new features or functionality menus Menu items and widget issues labels Dec 9, 2019
@sbatten sbatten removed their assignment Dec 9, 2019
@sbatten sbatten added this to the Backlog Candidates milestone Dec 9, 2019
@vscodebot
Copy link

vscodebot bot commented Jan 15, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodebot
Copy link

vscodebot bot commented Mar 6, 2020

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding

1 similar comment
@vscodebot
Copy link

vscodebot bot commented Mar 6, 2020

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding

@vscodebot
Copy link

vscodebot bot commented Mar 16, 2020

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Mar 16, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality menus Menu items and widget issues
Projects
None yet
Development

No branches or pull requests

2 participants